Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump iced from 0.10.0 to 0.12.1 #81

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2024

Bumps iced from 0.10.0 to 0.12.1.

Release notes

Sourced from iced's releases.

0.12.1

Added

  • extend and from_vec methods for Column and Row. #2264
  • PartialOrd, Ord, and Hash implementations for keyboard::Modifiers. #2270
  • clipboard module in advanced module. #2272
  • Default disabled style for checkbox and hovered style for Svg. #2273
  • From<u16> and From<i32> implementations for border::Radius. #2274
  • size_hint method for Component trait. #2275

Fixed

  • Black images when using OpenGL backend in iced_wgpu. #2259
  • Documentation for horizontal_space and vertical_space helpers. #2265
  • WebAssembly platform. #2271
  • Decouple Key from keyboard::Modifiers and apply them to text in KeyboardInput. #2238
  • Text insertion not being prioritized in TextInput and TextEditor. #2278
  • iced_tiny_skia clipping line strokes. #2282

Many thanks to...

0.12.0

Added

  • Multi-window support. #1964
  • TextEditor widget (or multi-line text input). #2123
  • Shader widget. #2085
  • Shadows. #1882
  • Vectorial text for Canvas. #2204
  • Layout consistency. #2192
  • Explicit text caching. #2058
  • Gradients in Oklab color space. #2055
  • Themer widget. #2209
  • Transform primitive. #2120
  • Cut functionality for TextEditor. #2215
  • Primary clipboard support. #2240
  • Disabled state for Checkbox. #2109
  • skip_taskbar window setting for Windows. #2211
  • fetch_maximized and fetch_minimized commands in window. #2189
  • run_with_handle command in window. #2200
  • show_system_menu command in window. #2243
  • text_shaping method for Tooltip. #2172
  • interaction method for MouseArea. #2207
  • hovered styling for Svg widget. #2163
  • height method for TextEditor. #2221
  • Customizable style for TextEditor. #2159
  • Customizable style for QRCode. #2229
  • Border width styling for Toggler. #2219

... (truncated)

Changelog

Sourced from iced's changelog.

[0.12.1] - 2024-02-22

Added

  • extend and from_vec methods for Column and Row. #2264
  • PartialOrd, Ord, and Hash implementations for keyboard::Modifiers. #2270
  • clipboard module in advanced module. #2272
  • Default disabled style for checkbox and hovered style for Svg. #2273
  • From<u16> and From<i32> implementations for border::Radius. #2274
  • size_hint method for Component trait. #2275

Fixed

  • Black images when using OpenGL backend in iced_wgpu. #2259
  • Documentation for horizontal_space and vertical_space helpers. #2265
  • WebAssembly platform. #2271
  • Decouple Key from keyboard::Modifiers and apply them to text in KeyboardInput. #2238
  • Text insertion not being prioritized in TextInput and TextEditor. #2278
  • iced_tiny_skia clipping line strokes. #2282

Many thanks to...

[0.12.0] - 2024-02-15

Added

  • Multi-window support. #1964
  • TextEditor widget (or multi-line text input). #2123
  • Shader widget. #2085
  • Shadows. #1882
  • Vectorial text for Canvas. #2204
  • Layout consistency. #2192
  • Explicit text caching. #2058
  • Gradients in Oklab color space. #2055
  • Themer widget. #2209
  • Transform primitive. #2120
  • Cut functionality for TextEditor. #2215
  • Primary clipboard support. #2240
  • Disabled state for Checkbox. #2109
  • skip_taskbar window setting for Windows. #2211
  • fetch_maximized and fetch_minimized commands in window. #2189
  • run_with_handle command in window. #2200
  • show_system_menu command in window. #2243
  • text_shaping method for Tooltip. #2172
  • interaction method for MouseArea. #2207
  • hovered styling for Svg widget. #2163
  • height method for TextEditor. #2221
  • Customizable style for TextEditor. #2159
  • Customizable style for QRCode. #2229
  • Border width styling for Toggler. #2219
  • RawText variant for Primitive in iced_graphics. #2158

... (truncated)

Commits
  • 9925729 Depend on 0.12.1 for iced_graphics and iced_renderer
  • 2da9fdc Remove adapter argument introduced to Backend in iced_wgpu
  • c1f41a4 Revert "Merge pull request #2280 from n1ght-hunter/add-action-fetch-location"
  • 4e8883b Merge branch 'master' into 0.12
  • ff49f58 Move fetch_position to next minor release
  • 3733f5b Update CHANGELOG
  • a27267b Merge pull request #2280 from n1ght-hunter/add-action-fetch-location
  • ce4eef6 Enable layout debugger for Wasm builds in tour example
  • 9339728 Update CHANGELOG
  • f693aa4 Use crate::core::Point instead of prefixing
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [iced](https://github.com/iced-rs/iced) from 0.10.0 to 0.12.1.
- [Release notes](https://github.com/iced-rs/iced/releases)
- [Changelog](https://github.com/iced-rs/iced/blob/master/CHANGELOG.md)
- [Commits](iced-rs/iced@0.10.0...0.12.1)

---
updated-dependencies:
- dependency-name: iced
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 1, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/iced-0.12.1 branch from 829f31d to 5e2b6dd Compare March 2, 2024 11:13
@friedow
Copy link
Owner

friedow commented Mar 2, 2024

Yeah :D this needs to be upgraded manually. This is probably not the only place it breaks stuff ;)

@a-kenji
Copy link
Collaborator

a-kenji commented Mar 2, 2024

I have a WIP branch. I can push it, it will need adjustment. But I think I got most things ready.

@a-kenji a-kenji force-pushed the dependabot/cargo/iced-0.12.1 branch from 5e2b6dd to 846e45f Compare March 2, 2024 13:52
@a-kenji a-kenji marked this pull request as draft March 2, 2024 13:55
@a-kenji a-kenji force-pushed the dependabot/cargo/iced-0.12.1 branch from 846e45f to 9a78fea Compare March 2, 2024 14:58
@friedow friedow mentioned this pull request Mar 26, 2024
@friedow friedow mentioned this pull request Apr 13, 2024
@friedow friedow self-assigned this Apr 13, 2024
@friedow friedow marked this pull request as ready for review April 15, 2024 08:06
@friedow
Copy link
Owner

friedow commented Apr 15, 2024

Alright, this is ready for another round of reviews :).

This hopefully fixes the problems with wgpu on some machines which is tracked in #109. @jesse-c, @MattMattV your testing on whether this resolves your issues would be highly appreciated :).

@friedow
Copy link
Owner

friedow commented Apr 15, 2024

Furthermore, this is the foundation to resolve the font fallback issues tracked in #128 and #103. Implementation of font fallback will follow in a separate PR.

@MattMattV
Copy link

Thank you very much for notifying !

Unfortunately this branch produce the same error for me.

Terminal output
~/clones/centerpiece dependabot/cargo/iced-0.12.1 ❯ nix develop
warning: ignoring untrusted substituter 'https://friedow.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring untrusted substituter 'https://friedow.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
(nix:nix-shell-env) [matthieu@mattpad centerpiece]$ RUST_BACKTRACE=full cargo run
    Updating crates.io index
  Downloaded freedesktop-desktop-entry v0.5.2
  Downloaded 1 crate (12.5 KB) in 0.66s
   Compiling libc v0.2.152
   Compiling rustix v0.38.30
   Compiling linux-raw-sys v0.4.12
   Compiling wayland-sys v0.31.1
   Compiling tracing-core v0.1.32
   Compiling quick-xml v0.31.0
   Compiling ahash v0.8.7
   Compiling raw-window-handle v0.6.0
   Compiling wayland-backend v0.3.3
   Compiling tracing-attributes v0.1.27
   Compiling slotmap v1.0.7
   Compiling smol_str v0.2.1
   Compiling as-raw-xcb-connection v1.0.1
   Compiling web-time v0.2.4
   Compiling glam v0.25.0
   Compiling xxhash-rust v0.8.10
   Compiling x11rb-protocol v0.13.0
   Compiling khronos-egl v6.0.0
   Compiling unicode-properties v0.1.1
   Compiling wgpu-hal v0.19.2
   Compiling gpu-alloc-types v0.3.0
   Compiling spirv v0.3.0+sdk-1.3.268.0
   Compiling drm-sys v0.6.1
   Compiling smithay-client-toolkit v0.18.1
   Compiling rustybuzz v0.11.0
   Compiling xkeysym v0.2.0
   Compiling unicode-bidi v0.3.14
   Compiling self_cell v1.0.3
   Compiling strict-num v0.1.1
   Compiling cursor-icon v1.1.0
   Compiling tiny-skia-path v0.11.4
   Compiling gpu-alloc v0.6.0
   Compiling wgpu-core v0.19.2
   Compiling wgpu-types v0.19.2
   Compiling linux-raw-sys v0.6.4
   Compiling glow v0.13.1
   Compiling drm-fourcc v2.2.0
   Compiling wayland-scanner v0.31.1
   Compiling tiny-skia v0.11.4
   Compiling getrandom v0.2.12
   Compiling memmap2 v0.9.4
   Compiling num_cpus v1.16.0
   Compiling memmap2 v0.8.0
   Compiling parking_lot_core v0.9.9
   Compiling hashbrown v0.14.3
   Compiling futures-executor v0.3.30
   Compiling fontdb v0.15.0
   Compiling parking_lot v0.12.1
   Compiling futures v0.3.30
   Compiling wgpu v0.19.2
   Compiling cfg_aliases v0.2.0
   Compiling tracing v0.1.40
   Compiling softbuffer v0.4.1
   Compiling indexmap v2.2.3
   Compiling gpu-descriptor v0.2.4
   Compiling ctor v0.2.7
   Compiling cosmic-text v0.10.0
   Compiling lru v0.12.3
   Compiling io-lifetimes v1.0.11
   Compiling kurbo v0.10.4
   Compiling winit v0.29.12
   Compiling x11-dl v2.21.0
   Compiling xkbcommon-dl v0.4.2
   Compiling blocking v1.5.1
   Compiling polling v2.8.0
   Compiling rustix v0.37.27
   Compiling naga v0.19.2
   Compiling socket2 v0.4.10
   Compiling tiny-xlib v0.2.2
   Compiling iced_core v0.12.2
   Compiling dirs-sys v0.3.7
   Compiling backtrace v0.3.69
   Compiling dirs v3.0.2
   Compiling time v0.3.31
   Compiling dbus v0.9.7
   Compiling sqlite3-sys v0.16.0
   Compiling serde_yaml v0.9.34+deprecated
   Compiling sqlite v0.33.0
   Compiling freedesktop-desktop-entry v0.5.2
   Compiling iced_futures v0.12.0
   Compiling iced_graphics v0.12.1
   Compiling iced_runtime v0.12.1
   Compiling iced_style v0.12.1
   Compiling anyhow v1.0.79
   Compiling simple_logger v4.3.3
   Compiling sysinfo v0.30.5
   Compiling async-io v1.13.0
   Compiling networkmanager v0.4.1
   Compiling polling v3.3.2
   Compiling drm-ffi v0.7.1
   Compiling calloop v0.12.4
   Compiling async-io v2.3.0
   Compiling drm v0.11.1
   Compiling async-global-executor v2.4.1
   Compiling wayland-client v0.31.2
   Compiling wayland-csd-frame v0.3.0
   Compiling async-std v1.12.0
   Compiling wayland-protocols v0.31.2
   Compiling calloop-wayland-source v0.2.0
   Compiling wayland-cursor v0.31.1
   Compiling x11rb v0.13.0
   Compiling wayland-protocols-wlr v0.2.0
   Compiling wayland-protocols-plasma v0.2.0
   Compiling clipboard_x11 v0.4.2
   Compiling iced_tiny_skia v0.12.1
   Compiling smithay-clipboard v0.7.1
   Compiling sctk-adwaita v0.8.1
   Compiling clipboard_wayland v0.2.2
   Compiling window_clipboard v0.4.1
   Compiling iced_winit v0.12.2
   Compiling glyphon v0.5.0
   Compiling iced_wgpu v0.12.1
   Compiling iced_renderer v0.12.1
   Compiling iced_widget v0.12.3
   Compiling iced v0.12.1
   Compiling centerpiece v1.0.0 (/home/matthieu/clones/centerpiece/client)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 36s
     Running `target/debug/centerpiece`
2024-04-15T08:47:54.745Z WARN  [sctk_adwaita::buttons] Ignoring unknown button type: icon
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] Unable to find extension: VK_KHR_surface
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] Unable to find extension: VK_KHR_xlib_surface
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] Unable to find extension: VK_KHR_xcb_surface
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] Unable to find extension: VK_KHR_wayland_surface
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] Unable to find extension: VK_EXT_swapchain_colorspace
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] Unable to find extension: VK_KHR_get_physical_device_properties2
2024-04-15T08:47:54.771Z WARN  [wgpu_hal::vulkan::instance] InstanceFlags::VALIDATION requested, but unable to find layer: VK_LAYER_KHRONOS_validation
2024-04-15T08:47:54.776Z WARN  [wgpu_hal::gles::egl] EGL_MESA_platform_surfaceless not available. Using default platform
thread 'main' panicked at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-hal-0.19.2/src/gles/egl.rs:799:88:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0:     0x555557224adb - ::fmt::h580634b3cf1e80d2
   1:     0x555557248ccc - core::fmt::write::h1907008f375a0f7f
   2:     0x5555572042fe - std::io::Write::write_fmt::h5d182c40a724ef6c
   3:     0x5555572248b5 - std::sys_common::backtrace::print::hb1b7da1f58c2e37d
   4:     0x555557225d93 - std::panicking::default_hook::{{closure}}::h7f74968e4c453ed8
   5:     0x555557225a95 - std::panicking::default_hook::h1b091f0aa6d8371d
   6:     0x555557226325 - std::panicking::rust_panic_with_hook::h951c7ebb95d3bb72
   7:     0x5555572261c6 - std::panicking::begin_panic_handler::{{closure}}::hc652a55312dedae5
   8:     0x555557224ce6 - std::sys_common::backtrace::__rust_end_short_backtrace::h7eaedff2f8f958bb
   9:     0x555557225f62 - rust_begin_unwind
  10:     0x555555769415 - core::panicking::panic_fmt::h2e7bf6f6dde740cb
  11:     0x5555557694b3 - core::panicking::panic::hd4dfdca7f0c595c1
  12:     0x555556dc47d5 - core::option::Option::unwrap::h639d7f269a4be0ed
                               at /build/rustc-1.74.0-src/library/core/src/option.rs:935:21
  13:     0x555556d13523 - >::init::h0cae2a4363f4aedc
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-hal-0.19.2/src/gles/egl.rs:799:31
  14:     0x555556c2fb46 - wgpu_core::instance::Instance::new::init::h239b4120b4d655a7
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-core-0.19.2/src/instance.rs:86:32
  15:     0x555556c2f79b - wgpu_core::instance::Instance::new::h104f2d68e47e217f
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-core-0.19.2/src/instance.rs:115:17
  16:     0x555556b6351e - wgpu_core::global::Global::new::hb46b100c5b9add1f
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-core-0.19.2/src/global.rs:59:23
  17:     0x555556a36ecb - ::init::hf92df14d82a7b7b4
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.19.2/src/backend/wgpu_core.rs:513:14
  18:     0x555556a5f834 - wgpu::Instance::new::h38a7bdce02d1116a
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.19.2/src/lib.rs:1833:36
  19:     0x5555559cfd91 - iced_wgpu::window::compositor::Compositor::request::{{closure}}::hbfd2ea937abb5cf4
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iced_wgpu-0.12.1/src/window/compositor.rs:29:24
  20:     0x555555803f38 - futures_executor::local_pool::block_on::{{closure}}::h5fb36306042f2b93
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-executor-0.3.30/src/local_pool.rs:317:23
  21:     0x555555803d99 - futures_executor::local_pool::run_executor::{{closure}}::h145c75b8b2008ff0
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-executor-0.3.30/src/local_pool.rs:90:37
  22:     0x5555559e1435 - std::thread::local::LocalKey::try_with::h17df740557a345f3
                               at /build/rustc-1.74.0-src/library/std/src/thread/local.rs:270:16
  23:     0x5555559e12cb - std::thread::local::LocalKey::with::h128ccd3703a29098
                               at /build/rustc-1.74.0-src/library/std/src/thread/local.rs:246:9
  24:     0x555555803cd4 - futures_executor::local_pool::run_executor::h2d6494eac38ea7ce
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-executor-0.3.30/src/local_pool.rs:86:5
  25:     0x555555803eba - futures_executor::local_pool::block_on::h07b0f88349b7889f
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-executor-0.3.30/src/local_pool.rs:317:5
  26:     0x5555559d2ea4 - iced_wgpu::window::compositor::new::h917e6419579f5da1
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iced_wgpu-0.12.1/src/window/compositor.rs:159:22
  27:     0x555555812ff0 - iced_renderer::compositor::Candidate::build::hc694955793aeaa64
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iced_renderer-0.12.1/src/compositor.rs:247:34
  28:     0x55555581380a - ::new::h4886f1e8c402dc31
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iced_renderer-0.12.1/src/compositor.rs:35:19
  29:     0x5555557a0594 - iced_winit::application::run::h1b95c38ac330e2c6
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iced_winit-0.12.2/src/application.rs:191:22
  30:     0x5555558d69f6 - iced::application::Application::run::h106553251e8014f0
                               at /home/matthieu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/iced-0.12.1/src/application.rs:208:12
  31:     0x5555559c1232 - centerpiece::main::hfbfe204478a73c0a
                               at /home/matthieu/clones/centerpiece/client/src/main.rs:13:5
  32:     0x5555557ab492 - core::ops::function::FnOnce::call_once::h1b50af899cefe6e1
                               at /build/rustc-1.74.0-src/library/core/src/ops/function.rs:250:5
  33:     0x5555559f666d - std::sys_common::backtrace::__rust_begin_short_backtrace::h0943e81816d623b8
                               at /build/rustc-1.74.0-src/library/std/src/sys_common/backtrace.rs:154:18
  34:     0x555555855aa6 - std::rt::lang_start::{{closure}}::h2b673fa0d9b4c398
                               at /build/rustc-1.74.0-src/library/std/src/rt.rs:166:18
  35:     0x555557202587 - std::rt::lang_start_internal::he83d9963a9dcb9b1
  36:     0x555555855a7a - std::rt::lang_start::h86f1733c6e5709f5
                               at /build/rustc-1.74.0-src/library/std/src/rt.rs:165:17
  37:     0x5555559c4cfe - main
  38:     0x7ffff7ca9fce - __libc_start_call_main
  39:     0x7ffff7caa089 - __libc_start_main_impl
  40:     0x555555769e95 - _start
  41:                0x0 - 
(nix:nix-shell-env) [matthieu@mattpad centerpiece]$

@friedow friedow merged commit e0bc049 into main Apr 15, 2024
1 check passed
@friedow friedow deleted the dependabot/cargo/iced-0.12.1 branch April 15, 2024 12:50
@friedow friedow restored the dependabot/cargo/iced-0.12.1 branch April 15, 2024 13:25
friedow added a commit that referenced this pull request Apr 15, 2024
friedow added a commit that referenced this pull request Apr 15, 2024
I noticed a negative performance impact after merging this. I'll revert
this for now.

Reverts #81
friedow added a commit that referenced this pull request Jul 30, 2024
After merging #81 I noticed a
performance impact while filtering entries in release builds. This is
why I reverted this change in
#130.

Feature wise this PR works but I would rather stay on the older version
if the new one decreases performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants