Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: Optimize Rect _onValueChanged callback. #2407
base: main
Are you sure you want to change the base?
refact: Optimize Rect _onValueChanged callback. #2407
Changes from 2 commits
36a6b7b
4cc5b86
38eea28
bd225cc
f70bd8c
ad9b43a
d49da11
3456275
ca3f4f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 20 in packages/math/src/Rect.ts
Codecov / codecov/patch
packages/math/src/Rect.ts#L20
Check warning on line 22 in packages/math/src/Rect.ts
Codecov / codecov/patch
packages/math/src/Rect.ts#L22
Check warning on line 41 in packages/math/src/Rect.ts
Codecov / codecov/patch
packages/math/src/Rect.ts#L41
Check warning on line 53 in packages/math/src/Rect.ts
Codecov / codecov/patch
packages/math/src/Rect.ts#L53
Check warning on line 65 in packages/math/src/Rect.ts
Codecov / codecov/patch
packages/math/src/Rect.ts#L65
Check warning on line 77 in packages/math/src/Rect.ts
Codecov / codecov/patch
packages/math/src/Rect.ts#L77