Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data instrumentation refactor #1998

Merged
merged 23 commits into from
Oct 16, 2023
Merged

Data instrumentation refactor #1998

merged 23 commits into from
Oct 16, 2023

Conversation

Robinnnnn
Copy link
Contributor

@Robinnnnn Robinnnnn commented Oct 6, 2023

Summary of Changes

This PR upgrades our analytics instrumentation and best practices.

Not captured in this PR / Next Steps

  • We should stop calling track manually and instead use a wrapped util that requires these props – especially eventContext, which will tie events together
  • Apply changes to a targeted flow like creating a post, optimistic syncing, refreshing errored NFTs, etc.
  • A handful of TODO: analytics for non-critical areas that were left untracked
  • Clearly laid out guidelines and best practices; this will be handled independently

Demo or Before/After Pics

No visual changes

Testing Steps

Pull down the PR and click around web / mobile apps

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:38pm

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Bundle Sizes

Compared against 35ffdca

Route Size (gzipped) Diff
/[username] 348.24 KB +2.1 KB
/[username]/[collectionId] 354.04 KB +2.11 KB
/[username]/followers 352.65 KB +2.15 KB
/[username]/galleries 372.77 KB +2.2 KB
/[username]/galleries/[galleryId] 351.04 KB +2.1 KB
/[username]/posts 715.76 KB +2.37 KB
/_app 346.82 KB +1.27 KB
/community/[chain]/[contractAddress] 700.75 KB +1.99 KB
/community/[chain]/[contractAddress]/live 710.03 KB +1.99 KB
/explore 345.93 KB +1.53 KB
/following 686.06 KB +1.92 KB
/home 685.65 KB +1.88 KB
/latest 685.53 KB +1.88 KB
/mobile 316.14 KB +1.52 KB
/post/[postId] 377.57 KB +2.24 KB
Dynamic import Size (gzipped) Diff
../src/contexts/relay/network.ts -> persisted_queries.json 65.61 KB -1.06 KB

* deprecate ButtonPill

* deprecate NonClickablePill

* implement GalleryPill with instrumentation

* refactor pills
* deprecate old GalleryLink, replace with InteractiveLink

* improve markdown internal links

* normalizeUrl

* track normalized URLs

* tracking for interactive links

* instrument badges

* deprecate ButtonLink

* refactor token, collection pages

* fix nested anchors in NftDetailText

* instrument LinkableAddress

* migrate DropdownLink

* distinguish internal vs external redirects

* migrate UnstyledLink

* refactor NavLink

* refactor ExplorePopoverList

* migrate ExploreUserCard

* deprecate unnecessary usages of next/link

* InteractiveLink -> GalleryLink

* disable direct imports from next/link

* migrate more components

* migrat NftPreview, GalleryNameDescriptionHeader, LinkToFullPageNftDetailModal

* migrate hover cards

* typecheck / lint pass

* migrate styled.a

* track notification clicks

* more tracking

* stopPropagation on pills, buttons

* GalleryLink instrumentation pass

* remaining links
* migrate dropdowns

* variant error -> delete
* initial pass

* second pass

* third pass

* InteractiveLink -> GalleryLink

* lints
* migrate () => {} to noop

* fix test
@Robinnnnn Robinnnnn marked this pull request as ready for review October 14, 2023 21:38
@Robinnnnn Robinnnnn changed the title [WIP] Web instrumentation refactor Data instrumentation refactor Oct 14, 2023
@Robinnnnn Robinnnnn enabled auto-merge (squash) October 16, 2023 21:46
@Robinnnnn Robinnnnn disabled auto-merge October 16, 2023 21:46
@Robinnnnn Robinnnnn merged commit 2e80ecc into main Oct 16, 2023
6 checks passed
@Robinnnnn Robinnnnn deleted the robin/web-data-instrumentation branch October 16, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant