-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data instrumentation refactor #1998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against 35ffdca
|
* deprecate ButtonPill * deprecate NonClickablePill * implement GalleryPill with instrumentation * refactor pills
* deprecate old GalleryLink, replace with InteractiveLink * improve markdown internal links * normalizeUrl * track normalized URLs * tracking for interactive links * instrument badges * deprecate ButtonLink * refactor token, collection pages * fix nested anchors in NftDetailText * instrument LinkableAddress * migrate DropdownLink * distinguish internal vs external redirects * migrate UnstyledLink * refactor NavLink * refactor ExplorePopoverList * migrate ExploreUserCard * deprecate unnecessary usages of next/link * InteractiveLink -> GalleryLink * disable direct imports from next/link * migrate more components * migrat NftPreview, GalleryNameDescriptionHeader, LinkToFullPageNftDetailModal * migrate hover cards * typecheck / lint pass * migrate styled.a * track notification clicks * more tracking * stopPropagation on pills, buttons * GalleryLink instrumentation pass * remaining links
* migrate dropdowns * variant error -> delete
4 tasks
* initial pass * second pass * third pass * InteractiveLink -> GalleryLink * lints
* migrate () => {} to noop * fix test
Robinnnnn
changed the title
[WIP] Web instrumentation refactor
Data instrumentation refactor
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR upgrades our analytics instrumentation and best practices.
eventContext
andeventFlow
to base tracking propseventContext
: a bucket, category, or general location for the event. e.g.Authentication
,Web Editor
eventFlow
: an explicit user flow that the event falls into e.g.Add Wallet Flow
orPost Flow
next/link
imports; refactoring all usages ofLink
,styled.a
, and<a />
to GalleryLinksButtonPills
,ClickablePill
,NonClickablePill
and consolidate intoGalleryPill
BaseM
; trash icon for delete options)DropdownItem
,DropdownLink
InteractiveLink
into trackedGalleryLink
clickDisabled
prop for PFPs to prevent unnecessary redirects and click takeoversNot captured in this PR / Next Steps
track
manually and instead use a wrapped util that requires these props – especiallyeventContext
, which will tie events togetherTODO: analytics
for non-critical areas that were left untrackedDemo or Before/After Pics
No visual changes
Testing Steps
Pull down the PR and click around web / mobile apps
Checklist
Please make sure to review and check all of the following: