Mobile instrumentation: eventContext refactor #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Robinnnnn
changed the base branch from
main
to
robin/web-data-instrumentation
Bundle SizesCompared against cc04911
Dynamic import: No significant changes found |
3 tasks
Robinnnnn
added a commit
that referenced
this pull request
Oct 16, 2023
* ensure correct mobile beta upsell banner is displayed on ios * update Button to autotrack * refactor components, WizardFooter * refactor global banners * rest of the owl * begin adding contexts * contexts pass * toss unused components * track more buttons * Web instrumentation: Pills (#2002) * deprecate ButtonPill * deprecate NonClickablePill * implement GalleryPill with instrumentation * refactor pills * Web instrumentation: Chips (#2004) * Web instrumentation: Links (#2007) * deprecate old GalleryLink, replace with InteractiveLink * improve markdown internal links * normalizeUrl * track normalized URLs * tracking for interactive links * instrument badges * deprecate ButtonLink * refactor token, collection pages * fix nested anchors in NftDetailText * instrument LinkableAddress * migrate DropdownLink * distinguish internal vs external redirects * migrate UnstyledLink * refactor NavLink * refactor ExplorePopoverList * migrate ExploreUserCard * deprecate unnecessary usages of next/link * InteractiveLink -> GalleryLink * disable direct imports from next/link * migrate more components * migrat NftPreview, GalleryNameDescriptionHeader, LinkToFullPageNftDetailModal * migrate hover cards * typecheck / lint pass * migrate styled.a * track notification clicks * more tracking * stopPropagation on pills, buttons * GalleryLink instrumentation pass * remaining links * Web Instrumentation: Dropdowns (#2014) * migrate dropdowns * variant error -> delete * Mobile instrumentation: eventContext refactor (#2015) * initial pass * second pass * third pass * InteractiveLink -> GalleryLink * lints * instrument Comments * ts fixes * Migrate noop functions to import noop (#2016) * migrate () => {} to noop * fix test * fix dropdown bug * remove merch unread dot * migrate PostsFeaturePage * web lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Part of #1998
eventContextin mobile gallery tracking propsInteractiveLinkMisc
BottomSheetRowinto its own component