Full implementation of AGN feedback for the cool-core destruction project #339

ShuangShuang0411 · 2024-07-18T06:49:27Z

This pull request includes the complete implementation of AGN feedback for the cool-core destruction project. The key components are:

The AGN feedback module in the ClusterMerger test problem.
The ExactCooling test problem for the currently private ExactCooling source term module.

Conflicts: src/Output/Output_DumpData_Total_HDF5.cpp

…ject

hyschive · 2024-07-20T03:26:54Z

@ShuangShuang0411 Some quick and general comments. I'll check the entire PR thoroughly after it is approved by other reviewers.

Make sure that this PR can reproduce the original results of the main branch, including but not limited to the ClusterMerger test. For example,
- The line # define NCOMP_PASSIVE_BUILTIN2 1 in Macro.h (and other similar lines/files related to cooling). should be activated only when enabling cooling. You may need to add a compilation option in configure.py to control the cooling module. Ask @ChunYen-Chen for details.
- You have slightly modified some parameters in Input__Parameter (e.g., MU_NORM, MIN_DENS, ...). @jzuhone What do you think about this? If you prefer, we can have different Input__Parameter files (in the same ClusterMerger folder) tailored for different applications.
Remove all trailing spaces
Replace all tabs with spaces
Polish the code format further to conform better with the GAMER style (e.g., indent, code alignment, add empty lines for separating different code segments, add more comments)
Fix all the CPU and GPU warning messages during compilation
IIRC, dual-energy is important when enabling cooling and/or feedback. Clarify that in README (along with other things that can be important; for example, how to conduct simulations with cooling and feedback in general).

hyschive · 2024-07-20T03:27:07Z

@jzuhone Since this PR is most related to your work, could you help review it? I'll also take a close look after you approve it.

First, do you prefer to modify the existing ClusterMerger test (as in the current PR) or add a new test problem?

jzuhone · 2024-07-20T03:28:29Z

@ShuangShuang0411 @hyschive I plan on reviewing this in detail over the next few days.

hyschive · 2024-07-24T08:53:19Z

src/SourceTerms/ExactCooling/dtSolver_ExactCooling.cpp

+   const int NT = 1;
+#  endif
+
+   double  dt_EC     = HUGE_NUMBER;


It would be great to still support this time-step criterion even though we may disable it by default.

hyschive · 2024-07-24T08:53:46Z

src/SourceTerms/ExactCooling/dtSolver_ExactCooling.cpp

+#  endif
+
+   double  dt_EC     = HUGE_NUMBER;
+   double *OMP_dt_EC = new double [NT];


It will cause memory leakage.

example/test_problem/Hydro/ClusterMerger/Input__TestProb

…gamer-fork into cool-core-public * 'cool-core-public' of ssh://github.com/ShuangShuang0411/gamer-fork: Abort if SRC_EXACTCOOLING is enabled before its release Include exact-cooling dt only when necessary Fix minor compilation issues in Init_GAMER.cpp and Mis_GetTimeStep.cpp

Co-authored-by: Chun-Yen Chen <[email protected]>

* main: (35 commits) Address review comments Record NCONREF_MAX Add check Reduce ConRef[] array size Rename ConservedRef* to ConRef* Restore file format Minor Apply suggestions from code review Bugfix Remove useless variable Simplify header Store conserved variables in an array Update comment Rename ConservedRefLoaded to ConservedRefInitialized Dump data before ELBDM_RemoveMotionCM() Minor Apply suggestions from code review Update comment Apply suggestions from code review Remove comments ... # Conflicts: # src/Output/Output_DumpData_Total_HDF5.cpp

src/Output/Output_DumpData_Total_HDF5.cpp

Co-authored-by: Chun-Yen Chen <[email protected]>

…inguish between the two halos

Co-authored-by: Chun-Yen Chen <[email protected]>

src/TestProblem/Hydro/ClusterMerger/Flu_ResetByUser_ClusterMerger.cpp

…uble --> real_par

ChunYen-Chen and others added 14 commits May 2, 2024 10:41

Record the todo

d840f8b

First workable version. (string not test yet)

95bf741

Store the string to HDF5

981e3f6

Remove the unused line

3214725

Free the struct

cc86bd0

Rename functions and add comments

9b8e208

Add template

8b5d100

Remove the unused

79ac400

Bug fix of storing string

7b62354

Update code style

79349d3

Move the code to proper place.

ede0744

Merge branch 'master' into hdf5_more_record

d9c5e1e

Conflicts: src/Output/Output_DumpData_Total_HDF5.cpp

Merge branch 'hyschive:main' into hdf5_more_record

43777a6

Full implementation of AGN feedback for the cool-core destruction pro…

423fa40

…ject

hyschive requested a review from jzuhone July 20, 2024 03:27

hyschive assigned jzuhone and hyschive and unassigned hyschive Jul 20, 2024

hyschive added enhancement hydro Hydrodynamics test Test problems gpu GPU issues and implementation labels Jul 20, 2024

hyschive mentioned this pull request Jul 20, 2024

AGN feedback implementation in the cool-core destruction project hyschive/gamer-fork#56

Closed

hyschive reviewed Jul 24, 2024

View reviewed changes

jzuhone reviewed Jul 26, 2024

View reviewed changes

example/test_problem/Hydro/ClusterMerger/Input__TestProb Outdated Show resolved Hide resolved

jzuhone reviewed Jul 26, 2024

View reviewed changes

example/test_problem/Hydro/ClusterMerger/Input__TestProb Outdated Show resolved Hide resolved

jzuhone and others added 11 commits February 10, 2025 07:48

Update src/SourceTerms/ExactCooling/CPU_Src_ExactCooling.cpp

690d373

Co-authored-by: Chun-Yen Chen <[email protected]>

Apply suggestions from code review

e84c87c

Co-authored-by: Chun-Yen Chen <[email protected]>

Apply suggestions from code review

da139db

Co-authored-by: Chun-Yen Chen <[email protected]>

Fix spelling

5df06a7

Fix alignments

39dbf5d

More cleanup and responding to comments

4fbb28d

nits

b027f93

resolve a number of issues

d7d0987

Remove unit parameters

a885ca5

jzuhone reviewed Feb 11, 2025

View reviewed changes

src/Output/Output_DumpData_Total_HDF5.cpp Show resolved Hide resolved

jzuhone and others added 10 commits February 11, 2025 10:51

Fixing more issues

da0d0d6

Apply suggestions from code review

12df224

Co-authored-by: Chun-Yen Chen <[email protected]>

Fix particle types but still allow for the same functionality to dist…

591dbf8

…inguish between the two halos

Remove unused array

87fbbc7

small fix

95794e9

Responding to reviewer comments

47766c7

Apply suggestions from code review

34ae3f6

Co-authored-by: Chun-Yen Chen <[email protected]>

Resolving more reviewer comments

45434cd

Responding to reviewer comments

aeebe4f

Responding to more reviewer comments

51e34c8

jzuhone reviewed Feb 13, 2025

View reviewed changes

src/TestProblem/Hydro/ClusterMerger/Flu_ResetByUser_ClusterMerger.cpp Outdated Show resolved Hide resolved

jzuhone added 7 commits February 13, 2025 10:01

Don't reset positions

0bc59a0

Responding to reviewer comments

6bfd78d

Creating and using Merger_Coll_NumBHs and fixing more instances of do…

1a0409e

…uble --> real_par

Bugfix

4318e47

Some work on accretion

0f7d7bd

Respond to reviewer comments

c91ff26

reset to script

8d750f5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full implementation of AGN feedback for the cool-core destruction project #339

Full implementation of AGN feedback for the cool-core destruction project #339

ShuangShuang0411 commented Jul 18, 2024

hyschive commented Jul 20, 2024

hyschive commented Jul 20, 2024 •

edited

Loading

jzuhone commented Jul 20, 2024

hyschive Jul 24, 2024

hyschive Jul 24, 2024

Full implementation of AGN feedback for the cool-core destruction project #339

Are you sure you want to change the base?

Full implementation of AGN feedback for the cool-core destruction project #339

Conversation

ShuangShuang0411 commented Jul 18, 2024

hyschive commented Jul 20, 2024

hyschive commented Jul 20, 2024 • edited Loading

jzuhone commented Jul 20, 2024

hyschive Jul 24, 2024

Choose a reason for hiding this comment

hyschive Jul 24, 2024

Choose a reason for hiding this comment

hyschive commented Jul 20, 2024 •

edited

Loading