-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full implementation of AGN feedback for the cool-core destruction project #339
Open
ShuangShuang0411
wants to merge
116
commits into
gamer-project:main
Choose a base branch
from
ShuangShuang0411:cool-core-public
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
d840f8b
Record the todo
ChunYen-Chen 95bf741
First workable version. (string not test yet)
ChunYen-Chen 981e3f6
Store the string to HDF5
ChunYen-Chen 3214725
Remove the unused line
ChunYen-Chen cc86bd0
Free the struct
ChunYen-Chen 9b8e208
Rename functions and add comments
ChunYen-Chen 8b5d100
Add template
ChunYen-Chen 79ac400
Remove the unused
ChunYen-Chen 7b62354
Bug fix of storing string
ChunYen-Chen 79349d3
Update code style
ChunYen-Chen ede0744
Move the code to proper place.
ChunYen-Chen d9c5e1e
Merge branch 'master' into hdf5_more_record
ChunYen-Chen 43777a6
Merge branch 'hyschive:main' into hdf5_more_record
ChunYen-Chen 423fa40
Full implementation of AGN feedback for the cool-core destruction pro…
ShuangShuang0411 cf8d491
Rename type. Store in compound.
ChunYen-Chen 608b734
Remove the old way
ChunYen-Chen 120bb5e
Add error msg. Minor
ChunYen-Chen f8c3e07
Add HDF5_Output_TestProb to all test problems
ChunYen-Chen b282292
Add an example
ChunYen-Chen 83ba968
Update comment
ChunYen-Chen 93f5730
Merge branch 'hdf5_more_record' of https://github.com/ChunYen-Chen/ga…
ChunYen-Chen 5c09f3c
Update Adding-New-Simulations.md
ChunYen-Chen 9b11556
Remove trailing spaces
ChunYen-Chen 00cc778
Replace tabs by spaces
ChunYen-Chen f2fa092
GAMER style
ChunYen-Chen 391fdd9
Bug fix
ChunYen-Chen c19d69f
Style
ChunYen-Chen 008ac34
Style
ChunYen-Chen 10a2e32
Use malloc. Style
ChunYen-Chen e311fbe
Merge branch 'hyschive:main' into hdf5_more_record
ChunYen-Chen c3d138e
Style
ChunYen-Chen 177b857
Define distance function
ChunYen-Chen 01758fd
Use the distance macro
ChunYen-Chen 5e9edd1
Style
ChunYen-Chen b3399d2
Optimize the initialization
ChunYen-Chen 555b602
Merge branch 'hdf5_more_record' into cool-core-chunyen
ChunYen-Chen e6ecf34
Add user HDF5 output
ChunYen-Chen efcad91
Update the HDF5 name
ChunYen-Chen 6134c57
Style
ChunYen-Chen 18d92fe
Bug fix and add load user HDF5 data function
ChunYen-Chen 719ecb4
Bug fix, support new HDF5 method, and remove old method
ChunYen-Chen 3b7d112
Remove BH_variable.bin
ChunYen-Chen 51edcfb
Bug fix
ChunYen-Chen 9aa1e7d
Merge remote-tracking branch 'origin/hdf5_more_record' into cool-core…
ChunYen-Chen d3e50f0
Bug fix
ChunYen-Chen 6bd1b2c
Style
ChunYen-Chen 7c4a746
Update comment
ChunYen-Chen 28f3848
Update the example
ChunYen-Chen 43adcfb
Rename the funciton pointer
ChunYen-Chen f22955b
Rename the function
ChunYen-Chen 8e47bae
Store the test problem id
ChunYen-Chen 58dfd4c
Add description
ChunYen-Chen 10a9d80
Rename the function
ChunYen-Chen b728dab
Rename funciton
ChunYen-Chen 29fb326
Bug fix
ChunYen-Chen b033a37
Change content
ChunYen-Chen b1af0af
Minor
ChunYen-Chen 6ab8e5a
Bug fix
ChunYen-Chen 83b8fe7
Merge remote-tracking branch 'origin/hdf5_more_record' into cool-core…
ChunYen-Chen 60486ae
Minor
ChunYen-Chen 358bf98
Rename the empty key
ChunYen-Chen e439650
Minor
ChunYen-Chen f4fd291
Merge remote-tracking branch 'origin/hdf5_more_record' into cool-core…
ChunYen-Chen 65fb821
Use static OpenMP schedule
ChunYen-Chen 6560733
Bug fix of hot accretion rate
ChunYen-Chen 47a6ad0
Merge pull request #1 from ChunYen-Chen/cool-core-chunyen
ShuangShuang0411 31d8a68
[Bugfix] Escape velocity
ChunYen-Chen bb151e4
[Bugfix] fixBH center location
ChunYen-Chen 0eeccbb
[Bugfix] Prototype
ChunYen-Chen 2bc6359
[Bugfix] Excluding SRHD
ChunYen-Chen 7fd7e8c
[Bugfix] Initial BH position
ChunYen-Chen fae7638
[Bugfix] Missing Output_HDF5_TestProb
ChunYen-Chen 2bc413c
[Bugfix] Remove outdated code
ChunYen-Chen 7ff90bd
[Bugfix] Check TOOL only when enable cooling
ChunYen-Chen 74fc76f
Review comments
ChunYen-Chen 0309317
Merge pull request #2 from ChunYen-Chen/cool-core-public
jzuhone 196b9f5
Apply suggestions from code review
jzuhone 8eb1035
Apply suggestions from code review
jzuhone 2a381b2
Merge branch 'main' into cool-core-public
jzuhone a8fded1
Addressing comments
jzuhone c6c6d25
Merge branch 'main' into cool-core-public
jzuhone 3399e65
Compilation fixes
b668a04
Fix minor compilation issues in Init_GAMER.cpp and Mis_GetTimeStep.cpp
hyschive d8c37c6
Code review suggestions
jzuhone 79ab80a
More responses to review
jzuhone b37892c
Include exact-cooling dt only when necessary
hyschive 747e918
Abort if SRC_EXACTCOOLING is enabled before its release
hyschive cf0fe3d
Merge pull request #3 from hyschive/cool-core-public
jzuhone 7d4cb84
Merge branch 'cool-core-public' of ssh://github.com/ShuangShuang0411/…
jzuhone 690d373
Update src/SourceTerms/ExactCooling/CPU_Src_ExactCooling.cpp
jzuhone e84c87c
Apply suggestions from code review
jzuhone da139db
Apply suggestions from code review
jzuhone 5df06a7
Fix spelling
jzuhone 39dbf5d
Fix alignments
jzuhone 4fbb28d
More cleanup and responding to comments
jzuhone b027f93
nits
jzuhone d7d0987
resolve a number of issues
jzuhone a885ca5
Remove unit parameters
jzuhone 800009d
Merge branch 'main' into cool-core-public
jzuhone da0d0d6
Fixing more issues
jzuhone 12df224
Apply suggestions from code review
jzuhone 591dbf8
Fix particle types but still allow for the same functionality to dist…
jzuhone 87fbbc7
Remove unused array
jzuhone 95794e9
small fix
jzuhone 47766c7
Responding to reviewer comments
jzuhone 34ae3f6
Apply suggestions from code review
jzuhone 45434cd
Resolving more reviewer comments
jzuhone aeebe4f
Responding to reviewer comments
jzuhone 51e34c8
Responding to more reviewer comments
jzuhone 0bc59a0
Don't reset positions
jzuhone 6bfd78d
Responding to reviewer comments
jzuhone 1a0409e
Creating and using Merger_Coll_NumBHs and fixing more instances of do…
jzuhone 4318e47
Bugfix
jzuhone 0f7d7bd
Some work on accretion
jzuhone c91ff26
Respond to reviewer comments
jzuhone 8d750f5
reset to script
jzuhone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Level User-defined Criteria | ||
0 6.0 | ||
1 6.0 | ||
2 6.0 | ||
3 6.0 | ||
4 6.0 | ||
5 6.0 | ||
6 6.0 | ||
7 6.0 | ||
8 6.0 | ||
9 6.0 | ||
10 6.0 | ||
11 6.0 | ||
12 6.0 | ||
13 6.0 | ||
14 6.0 | ||
15 6.0 | ||
16 6.0 | ||
17 6.0 | ||
18 6.0 | ||
19 6.0 | ||
20 6.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,62 @@ | ||
# problem-specific runtime parameters | ||
Merger_Coll_NumHalos 2 # number of halos | ||
Merger_Coll_NumHalos 2 # number of halos | ||
|
||
# parameters for cluster 1 | ||
Merger_File_Prof1 profile1_gamer.h5 # profile table of cluster 1 | ||
Merger_File_Prof1 profile1_gamer.h5 # profile table of cluster 1 | ||
Merger_File_Par1 1to3_b0.0_gamerp_1.h5 # particle file of cluster 1 | ||
Merger_Coll_PosX1 6000.0 # X-center of cluster 1 in kpc | ||
Merger_Coll_PosY1 7500.0 # Y-center of cluster 1 in kpc | ||
Merger_Coll_VelX1 375.0 # X-velocity of cluster 1 in km/s | ||
Merger_Coll_VelY1 0.0 # Y-velocity of cluster 1 in km/s | ||
Merger_Coll_IsGas1 1 # If cluster 1 should have gas and not have DM only | ||
Merger_Coll_PosX1 6000.0 # X-center of cluster 1 in kpc | ||
Merger_Coll_PosY1 7500.0 # Y-center of cluster 1 in kpc | ||
Merger_Coll_VelX1 375.0 # X-velocity of cluster 1 in km/s | ||
Merger_Coll_VelY1 0.0 # Y-velocity of cluster 1 in km/s | ||
Merger_Coll_IsGas1 1 # If cluster 1 should have gas and not have DM only | ||
Bondi_MassBH1 3.4e8 # black hole mass (in Msun) | ||
Mdot_BH1 0.0 # accretion rate of cluster 1 in Msun/yr | ||
Jet_HalfHeight1 0.70 # jet 1: half height of the cylinder-shape jet source (in kpc) | ||
Jet_Radius1 0.35 # jet 1: radius of the cylinder-shape jet source (in kpc) | ||
|
||
# parameters for cluster 2 | ||
Merger_File_Prof2 profile2_gamer.h5 # profile table of cluster 2 | ||
Merger_File_Prof2 profile2_gamer.h5 # profile table of cluster 2 | ||
Merger_File_Par2 1to3_b0.0_gamerp_2.h5 # particle file of cluster 2 | ||
Merger_Coll_PosX2 9000.0 # X-center of cluster 2 in kpc | ||
Merger_Coll_PosY2 7500.0 # Y-center of cluster 2 in kpc | ||
Merger_Coll_VelX2 -1125.0000000000002 # X-velocity of cluster 2 in km/s | ||
Merger_Coll_VelY2 0.0 # Y-velocity of cluster 2 in km/s | ||
Merger_Coll_IsGas2 1 # If cluster 2 should have gas and not have DM only | ||
Merger_Coll_PosX2 9000.0 # X-center of cluster 2 in kpc | ||
Merger_Coll_PosY2 7500.0 # Y-center of cluster 2 in kpc | ||
Merger_Coll_VelX2 -1125.0000000000002 # X-velocity of cluster 2 in km/s | ||
Merger_Coll_VelY2 0.0 # Y-velocity of cluster 2 in km/s | ||
Merger_Coll_IsGas2 1 # If cluster 2 should have gas and not have DM only | ||
Bondi_MassBH2 3.4e8 # black hole mass (in Msun) | ||
Mdot_BH2 0.0 # accretion rate of cluster 2 in Msun/yr | ||
Jet_HalfHeight2 0.70 # jet 2: half height of the cylinder-shape jet source (in kpc) | ||
Jet_Radius2 0.35 # jet 2: radius of the cylinder-shape jet source (in kpc) | ||
|
||
# parameters for cluster 3 (disabled for this example) | ||
Merger_File_Prof3 none # profile table of cluster 3 | ||
Merger_File_Par3 none # particle file of cluster 3 | ||
Merger_Coll_PosX3 0 # X-center of cluster 3 in kpc | ||
Merger_Coll_PosY3 0.0 # Y-center of cluster 3 in kpc | ||
Merger_Coll_VelX3 0.0 # X-velocity of cluster 3 in km/s | ||
Merger_Coll_VelY3 0.0 # Y-velocity of cluster 3 in km/s | ||
Merger_Coll_IsGas3 0 # If cluster 3 should have gas and not have DM only | ||
Merger_File_Prof3 none # profile table of cluster 3 | ||
Merger_File_Par3 none # particle file of cluster 3 | ||
Merger_Coll_PosX3 0 # X-center of cluster 3 in kpc | ||
Merger_Coll_PosY3 0.0 # Y-center of cluster 3 in kpc | ||
Merger_Coll_VelX3 0.0 # X-velocity of cluster 3 in km/s | ||
Merger_Coll_VelY3 0.0 # Y-velocity of cluster 3 in km/s | ||
Merger_Coll_IsGas3 0 # If cluster 3 should have gas and not have DM only | ||
Bondi_MassBH3 3.4e8 # black hole mass (in Msun) | ||
Mdot_BH3 0.0 # accretion rate of cluster 3 in Msun/yr | ||
Jet_HalfHeight3 0.70 # jet 3: half height of the cylinder-shape jet source (in kpc) | ||
Jet_Radius3 0.35 # jet 3: radius of the cylinder-shape jet source (in kpc) | ||
|
||
# parameters of AGN jet feedback | ||
AGN_feedback 0 # turn on/off (1/0) AGN feedback | ||
Accretion_Mode 1 # 1: hot mode; 2: code mode; 3: combine (hot + cold) | ||
eta 1.0 # mass loading factor in jet feedback | ||
eps_f 0.001 # the radiative efficiency in jet feedback | ||
eps_m 0.0 # the fraction of total energy that goes into the thermal energy in jet feedback | ||
R_acc 4.0 # accretion radius: compute the accretion rate (in kpc) | ||
R_dep 4.0 # radius to deplete the accreted gas (in kpc) | ||
JetDirection_case 1 # Methods for choosing the jet direction: | ||
# 1: Fixed at x-axis | ||
# 2: Import from table (generate JetDirection.txt) | ||
# 3: Align with angular momentum | ||
|
||
# other parameters | ||
Merger_Coll_UseMetals 0 # look for a metal field in the profile files | ||
Merger_Coll_UseMetals 0 # look for a metal field in the profile files [1] | ||
Merger_Coll_LabelCenter 1 # label the particle closest to the center of each cluster [1] | ||
AdjustBHPos 1 # (true/false) --> Adjust the BH position | ||
AdjustBHVel 0 # (true/false) --> Adjust the BH velocity | ||
AdjustPeriod 10 # the time interval of adjustment (in Myr) | ||
fixBH 0 # fix the BH at the simulation box center and set its velocity to be zero (1 cluster only) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Mismatch] There are many parameters mismatched to your manuscript, e.g. accretion mode, and jet radius. Should we make them consistent?