Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRHD with CR #345

Open
wants to merge 82 commits into
base: main
Choose a base branch
from
Open

SRHD with CR #345

wants to merge 82 commits into from

Conversation

ChunYen-Chen
Copy link
Collaborator

@ChunYen-Chen ChunYen-Chen commented Aug 21, 2024

This PR includes the works Can the symmetric Fermi and eROSITA bubbles be produced by tilted jets? from @zengbs.

Updates

  1. SRHD supports CRs and gravity.
  2. New Fermi bubble test problem.

TODO

  • Upload the initial condition. (yt.upload is malfunctioning now)

Results

Fermi bubble test

@ChunYen-Chen ChunYen-Chen marked this pull request as ready for review August 22, 2024 05:31
@jzuhone
Copy link
Contributor

jzuhone commented Aug 23, 2024

@ChunYen-Chen I see in your presentation these lines:

Code:
1. Add more unphysical checks. e.g. passive scalars
2. Bugs fix of EoS: The initial guess of HTilde when solving temperature.
3. The unit of temperature output is changed from code unit to Kelvin.

Regarding 2: we fixed such a bug in the merged SRHD PR. Was there another one?
Regarding 3: I thought that the output temperature units were already in Kelvin? We had this discussion previously as well, and yt certainly seems to think the units are Kelvin.

@hyschive
Copy link
Contributor

@jzuhone You are right that both 2 and 3 have already been merged into GAMER early this year in #185. IIUC, @ChunYen-Chen's slides are referring to @zengbs's own branch used in his Fermi/eROSITA bubbles paper that didn't incorporate #185.

@ChunYen-Chen @zengbs Please correct me if I'm wrong.

@hyschive hyschive self-requested a review September 9, 2024 03:42
@hyschive hyschive self-assigned this Sep 9, 2024
@hyschive hyschive added enhancement hydro Hydrodynamics test Test problems labels Sep 9, 2024
@ChunYen-Chen
Copy link
Collaborator Author

@hyschive The branch is updated to the latest main branch.

@ChunYen-Chen ChunYen-Chen mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hydro Hydrodynamics test Test problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants