Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructive recognition for SL_n #330

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add constructive recognition for SL_n #330

wants to merge 15 commits into from

Conversation

danielrademacher
Copy link
Collaborator

No description provided.

@fingolfin fingolfin changed the title Include constructive recognition sl Add constructive recognition for SL_n Jun 19, 2024
fingolfin
fingolfin reviewed Jun 19, 2024
View reviewed changes
PackageInfo.g
@@ -268,6 +268,7 @@ Dependencies := rec(
GAP := ">=4.11",
NeededOtherPackages := [
["AtlasRep", ">= 1.4.0"],
["Alnuth", ">= 3.2.1"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

PackageInfo.g
@@ -18,7 +18,7 @@ SetPackageInfo( rec(

PackageName := "recog",
Subtitle := "A package for constructive recognition of permutation and matrix groups",
Version := "1.4.2",
Version := "1.4.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version := "1.4.3",
Version := "1.4.3-DEV",

gap/projective/constructive_recognition/utils/achieve.gi Outdated
@@ -1294,12 +1138,12 @@ RECOG.RecogniseSL2NaturalEvenChar := function(g,f,torig)
xm := o[j];
j := j + 1;
c := Comm(tm,xm);
until not IsOne(c^2);
until not(IsOne(c^2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
until not(IsOne(c^2));
until not IsOne(c^2);

and similar in other places where these parentheses are added back.

gap/projective/constructive_recognition/utils/achieve.gi Outdated
@@ -3246,10 +2330,10 @@ function(ri, g)
Info(InfoRecog,2,"ClassicalNatural: this is PSL_2!");
if IsEvenInt(q) then
std := RECOG.RecogniseSL2NaturalEvenChar(gm,f,false);
ri!.comment := "PSL2Even";
ri!.comment := "_PSL2Even";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this was changed? It causes CI tests to fail

Suggested change
ri!.comment := "_PSL2Even";
ri!.comment := "PSL2Even";

gap/projective/constructive_recognition/utils/achieve.gi Outdated
else
std := RECOG.RecogniseSL2NaturalOddCharUsingBSGS(gm,f);
ri!.comment := "PSL2Odd";
ri!.comment := "_PSL2Odd";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ri!.comment := "_PSL2Odd";
ri!.comment := "PSL2Odd";

gap/projective/constructive_recognition/utils/achieve.gi Outdated
@@ -3270,12 +2354,12 @@ function(ri, g)
# FIXME: Note d=3 currently has a problem in the SL2-finder.
Info(InfoRecog,2,"Classical natural: SL(",d,",",q,"): small ",
"case, handing over to Schreier-Sims.");
ri!.comment := Concatenation("SL(",String(d),",",String(q),")",
ri!.comment := Concatenation("_SL(",String(d),",",String(q),")",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ri!.comment := Concatenation("_SL(",String(d),",",String(q),")",
ri!.comment := Concatenation("SL(",String(d),",",String(q),")",

gap/projective/constructive_recognition/utils/achieve.gi Outdated
@@ -3285,7 +2369,7 @@ function(ri, g)
x->std.basi*x*std.bas));
ri!.fakegens := RECOG.InitSLfake(f,d);
ri!.fakegens.count := 0;
ri!.comment := "PSLd";
ri!.comment := "_PSLd";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ri!.comment := "_PSLd";
ri!.comment := "PSLd";

@fingolfin
Copy link
Member

Sometimes this still runs into an error:

gap> res:=RECOG.FindStdGensSmallerMatrices_SL(SL(50,5)); time;
Error, List Element: <list>[2] must have an assigned value in
  for ele in eigenspaceGenerators[2] do
    vec := zerovec;
    for j in [ 1 .. Size( ele ) ] do
        vec := vec + ele[j] * result[j];
    od;
    Add( sl2eigenspacebase, vec );
od; at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/GoingDown.gi:605 called from
RECOG.Computesl2Subspace( baselist, eigenspacelist
 ) at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/GoingDown.gi:545 called from
RECOG.SLn_constructsl2WithSmallerMatrices( sld, d, q
 ) at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/main.gi:162 called from
<function "unknown">( <arguments> )
 called from read-eval loop at *stdin*:2
type 'quit;' to quit to outer loop

fingolfin and others added 3 commits June 20, 2024 12:37
@fingolfin
Remove some dead (commented out) code
01c2703
@fingolfin
Restore some code
3847eb7
@ThomasBreuer @fingolfin
fix more places where the current directory is needed
36bbef1 
If one wants to build the documentation with version 1.4.3 of
PackageManager then also the calls of `OutputTextFile` require paths
relative to `DirectoryCurrent()`.
@fingolfin
Copy link
Member

The TestRecogGL tests systematically fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielrademacher @fingolfin @ThomasBreuer