Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructive recognition for SL_n #330

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
3 changes: 2 additions & 1 deletion PackageInfo.g
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ SetPackageInfo( rec(

PackageName := "recog",
Subtitle := "A package for constructive recognition of permutation and matrix groups",
Version := "1.4.2",
Version := "1.4.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version := "1.4.3",
Version := "1.4.3-DEV",

Date := "27/09/2022", # dd/mm/yyyy format
License := "GPL-3.0-or-later",

Expand Down Expand Up @@ -268,6 +268,7 @@ Dependencies := rec(
GAP := ">=4.11",
NeededOtherPackages := [
["AtlasRep", ">= 1.4.0"],
["Alnuth", ">= 3.2.1"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

["FactInt", ">= 1.5.2"],
["Forms", ">= 1.2"],
["genss", ">= 1.3"],
Expand Down
3 changes: 3 additions & 0 deletions gap/base/kernel.gi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ BindGlobal( "GenerateRandomKernelElementsAndOptionallyVerifyThem",
verificationSuccess := true;
# We generate a random element of the kernel as the quotient of a random
# element and the preimage of its image under the homomorphism.
Info(InfoRecog,3, "GenerateRandomKernelElementsAndOptionallyVerifyThem, n = ", n);

for i in [1 .. n] do
Info(InfoRecog,3, "GenerateRandomKernelElementsAndOptionallyVerifyThem: ", i, " / ", n);
# Finding kernel generators and immediate verification must use
# different random elements! This is ensured by using the same stamp
# in both situations.
Expand Down
Loading
Loading