[Feature] Allow specifying the alarm volume using steps/stops #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by #282
This PR allows
alarm
users to speicfy a staircase function to control the alarm volume.It also fixes #267 by adding this line. For some reason AVAudioPlayer ignores volume changes unless the initial volume is set to zero.
PS: Overall, AVAudioPlayer has been a pain to deal with,
setVolume
has bugs, and it also doesn't report the real.volume
value while a fade is in progress.I've also taken the liberty to fix lint warnings in both iOS and Android native code.
I've tested using iOS and Android emulators + iOS physical device. I would appreciate if you could test this as well before merging. Thanks!