Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Pigeon #292

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Migrate to Pigeon #292

merged 7 commits into from
Dec 2, 2024

Conversation

orkun1675
Copy link
Contributor

This PR refactors Flutter-Platform communications using Pigeon.

It also simplifies some code, improves error handling, updates dependencies, and fixes some lint warnings.

@gdelataillade gdelataillade added the reviewing This PR is being reviewed label Nov 25, 2024
Copy link
Owner

@gdelataillade gdelataillade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the hard work! I’ve left a few comments on your changes—please feel free to reach out if you need any help or have any questions. Great job!

lib/service/alarm_storage.dart Outdated Show resolved Hide resolved
example/lib/screens/home.dart Outdated Show resolved Hide resolved
lib/alarm.dart Show resolved Hide resolved
pigeons/alarm_api.dart Outdated Show resolved Hide resolved
ios/Classes/services/NotificationManager.swift Outdated Show resolved Hide resolved
@orkun1675
Copy link
Contributor Author

All issues addressed, please take another look.

Copy link
Owner

@gdelataillade gdelataillade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdelataillade gdelataillade merged commit 6953bd9 into gdelataillade:main Dec 2, 2024
1 check passed
@gdelataillade
Copy link
Owner

Added to alarm 4.1.0. Thanks for the contribution !

@orkun1675 orkun1675 deleted the pigeon branch December 10, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewing This PR is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants