Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Show app on lock screen when alarm rings #294

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

orkun1675
Copy link
Contributor

@orkun1675 orkun1675 commented Nov 24, 2024

The current Android instructions result in the app being shown on the lock-screen permanently. This is likely not desired by all apps.

This PR dynamically shows the app on the lock-screen and turns the screen on when an alarm rings AND reverts showing the app on the lock-screen once the alarm is stopped.

This PR is branched from #292, please see this commit for diffs.

@gdelataillade
Copy link
Owner

Awesome ! I'll review it as soon as I merge #292. Thanks for the work !

@orkun1675 orkun1675 mentioned this pull request Nov 27, 2024
@gdelataillade
Copy link
Owner

This PR needs to be updated to align with the latest review changes introduced in the Pigeon migration #292.

@orkun1675
Copy link
Contributor Author

Branch is now up to date w/ main. PTAL.

Copy link
Owner

@gdelataillade gdelataillade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdelataillade gdelataillade merged commit c62bcfd into gdelataillade:main Dec 3, 2024
1 check passed
@gdelataillade
Copy link
Owner

Thanks for your work ! I just released version 4.1.1 with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants