Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Francesco et #17

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from
Draft

Francesco et #17

wants to merge 74 commits into from

Conversation

FrancescoGrossi-unimi
Copy link
Collaborator

adapted code to work woth le instead of gpp

@fabern fabern mentioned this pull request Oct 1, 2024
@fabern fabern marked this pull request as draft October 1, 2024 10:11
@fabern
Copy link
Member

fabern commented Oct 1, 2024

Thanks Francesco!

As discussed: you can now compute seperately your validation of ET/LE outputs with the current state of this branch and of GPP outputs with the main branch. This should allow you to continue with your analysis for the thesis.

Before we merge this PR into the main branch, I will need to add again the ability to validate it against gpp.

TODO for Fabian:

  • make this PR generic for le AND gpp AND netrad (see fdk worksflow for preparing forcing data #5). The goal is to reuse parts of the code that are similar between le, gpp, netrad. Instead of copy/pasting it would be better to create functions that work for all use cases.

@stineb
Copy link
Collaborator

stineb commented Oct 2, 2024

@FrancescoGrossi-unimi will also need to run the benchmarking for GPP (in addition to LE). Having said that, he should get to results as directly as possible and we don't want to expect from him to advance the sofunCalVal repo at this stage (weeks before submission of this thesis). Therefore, could you @fabern @FrancescoGrossi-unimi please discuss how to best go forward to best use synergies but also to minimise the responsibilities of Francesco at this point?

FrancescoGrossi-unimi and others added 29 commits October 11, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants