Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres integration #1427

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Postgres integration #1427

wants to merge 2 commits into from

Conversation

mathanmahe
Copy link

@mathanmahe mathanmahe commented Nov 26, 2023 •
edited
Loading

Related to issue #1331

Postgres implementation is complete, string_agg is incomplete

@mathanmahe mathanmahe mentioned this pull request Nov 26, 2023
Open
@mathanmahe mathanmahe changed the title Mathan postgres integration Postgres integration Nov 27, 2023
americast
americast requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@americast americast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @mathanmahe! It would be great if you could enlist psycopg2 as a dependency in setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@americast americast americast requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathanmahe @americast