feat(connectors): add raspiblitz #683

secondl1ght · 2022-03-12T00:03:11Z

Link this PR to an issue

Fixes #673

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Describe the changes you have made in this PR -

Begin to add the RaspiBlitz connector, I repurposed the LND one for this because the backend should be the same. I still need to add the RaspiBlitz specific steps to this so if anyone knows those can they please post them here.

Screenshots of the changes (If any) -

How Has This Been Tested?

I added a LND node successfully.

Checklist:

My code follows the style guidelines of this project and performed a self-review of my own code
New and existing tests pass locally with my changes
I have made corresponding changes to the documentation (If Any)

secondl1ght · 2022-03-12T00:09:32Z

Note: This PR is not ready to be merged, we need to add the Raspi specific details first.

escapedcat · 2022-03-12T05:45:05Z

Note: This PR is not ready to be merged

Wanna switch it to draft till it's ready to indicate it?

secondl1ght · 2022-03-12T05:58:34Z

I don't see the button to do that..?

escapedcat · 2022-03-12T10:13:18Z

Upper right:

Or when you open a PR you can select it here:

secondl1ght · 2022-03-18T01:21:11Z

Ok I have added the instructions for this and it is now ready for review, @MoritzKa do you want to verify everything looks correct?

MoritzKa · 2022-03-18T09:22:16Z

Thanks. I´ve two points to report

adjust instruction to ...":8080 at the end"
I could not test the connection. The build has different ID than the companion app is configured for.

bumi · 2022-03-18T10:25:03Z

@MoritzKa you can change the ID in that JSON file.

MoritzKa · 2022-03-18T11:10:59Z

Changed the ID. Connection works fine!

bumi · 2022-03-18T11:28:24Z

We don't need the macaroon drag&drop here - we have specific instructions how users get the macaroon hex above. So we should remove that.

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx

secondl1ght · 2022-03-18T16:45:16Z

Ok I have made all the changes, have a look:

MoritzKa · 2022-03-18T16:47:21Z

ACK

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx

secondl1ght · 2022-03-21T00:19:39Z

I updated the code so that https:// and port:8080 get added automatically to keep it as simple as possible for the user.

…-support feature/lud 18 email support

feat: new wallet account creation with lightning address

…e-internet-explorer feat: upgrade to react 18

setup i18next react-i18next browser-language-detector create locale switcher styling for both light and dark mode translate heading enable json imports in tsconfig language persistence throughout different components language persistence between different sessions browser language detections format JSON translation file using built-in eslint JSON formatted and run automated using lintstaged format existing json file place language switcher on intro and under settings (for intro under development mode) store locale in extensions storage signed-off-by: pavan joshi <[email protected]>

signed-off-by: pavan joshi <[email protected]>

secondl1ght · 2022-04-02T03:41:55Z

Ok I refactored the code so that it now checks for http and adds https if the user does not enter that themselves.

All that we need to do now is resolve the merge conflicts - but for some reason GitHub won't let me resolve them. The 'resolve conflicts' button is disabled for me...

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx

fix: update citadel sdk for core lightning support

…-04-04 Update all development Yarn dependencies (2022-04-04)

feat(i18n): initial setup

…ning-browser-extension into secondl1ght-add-raspiblitz

secondl1ght · 2022-04-05T21:21:11Z

Ok so resolving the merge conflicts was a bit of a hassle! GitHub wouldn't let me do it on the website because it said the conflicts were too complex. So I did it locally, I ended up having to create a new branch on this repo and merging this PR onto master on that new branch. I then tried to push those changes back to this PR but it looks like something happened during that so this PR is now not correct. Easiest solution was to to create a new PR from the new branch and I did that with #777. We can leave this PR open to track the conversation history but we should merge #777 and then close this one when it gets merged. Hopefully what I explained here makes sense.

AustinKelsay and others added 6 commits January 20, 2022 10:31

Adding userEmail value to types and state

bf09fbb

Adding in email form on frontend and payerdata parsing function

df26f63

Removing extra 'or' operator

3162632

Merge master

c1deabc

Simplifying variable checks on getPayerData

0fd092c

feat(connectors): add raspiblitz

26d9f05

secondl1ght mentioned this pull request Mar 12, 2022

Add RaspiBlitz connector #673

Closed

secondl1ght marked this pull request as draft March 12, 2022 14:45

feat: add instructions

da20da1

secondl1ght marked this pull request as ready for review March 18, 2022 01:21

Merge branch 'master' into add-raspiblitz

ae0fd7a

bumi reviewed Mar 18, 2022

View reviewed changes

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx Outdated Show resolved Hide resolved

bumi reviewed Mar 18, 2022

View reviewed changes

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx Outdated Show resolved Hide resolved

secondl1ght added 2 commits March 18, 2022 10:34

Merge branch 'getAlby:master' into add-raspiblitz

75d88e1

refactor: remove upload macaroon, update port, update textfield

f339b51

bumi requested changes Mar 19, 2022

View reviewed changes

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx Outdated Show resolved Hide resolved

feat: add https and port for user automatically

6128c80

secondl1ght requested a review from bumi March 21, 2022 00:19

bumi and others added 16 commits March 31, 2022 00:26

Merge pull request getAlby#541 from AustinKelsay/feature/lud-18-email…

0b4c1bc

…-support feature/lud 18 email support

feat: input suffix

2062916

feat: upgrade to react 18

3f6877f

Update @tailwindcss/forms to version 0.5.0

9158683

fix: the LNURL payerdata and commentsAllowed is optional

48b8b1d

feat: nest webln calls under the webln/ namespace

ad399ca

chore: ignore the action in the message for now we still use type

34a178f

Merge pull request getAlby#757 from getAlby/feature/new-signup

7de48b0

feat: new wallet account creation with lightning address

v1.9.0

42f206c

fix: signMessage call

022637b

v1.9.1

a7410e0

Merge pull request getAlby#764 from getAlby/feature/hello-react-18-by…

e724fb2

…e-internet-explorer feat: upgrade to react 18

refactor: some minor improvements

36c1efd

signed-off-by: pavan joshi <[email protected]>

fix: update citadel sdk for core lightning support

f05e50f

feat: check for http and add if not present

d7f1aac

bumi reviewed Apr 2, 2022

View reviewed changes

src/app/screens/Onboard/ConnectRaspiBlitz/index.tsx Outdated Show resolved Hide resolved

bumi and others added 9 commits April 3, 2022 09:48

Merge pull request getAlby#769 from runcitadel/fix/core-ln-citadel

6516983

fix: update citadel sdk for core lightning support

Update all development Yarn dependencies (2022-04-04)

44a396e

Merge pull request getAlby#772 from getAlby/depfu/batch_dev/yarn/2022…

bf63762

…-04-04 Update all development Yarn dependencies (2022-04-04)

Merge pull request getAlby#711 from pavanjoshi914/i18n-inital-setup

369c507

feat(i18n): initial setup

refactor: use bumi suggestion to dry handleUrl function

206d1f7

Merge branch 'add-raspiblitz' of https://github.com/secondl1ght/light…

f256fd9

…ning-browser-extension into secondl1ght-add-raspiblitz

fix: add raspiblitz back in after merge

3a819ad

fix: delete unused code

304eb52

fix: filepath

e9a41f4

secondl1ght mentioned this pull request Apr 5, 2022

feat: add RaspiBlitz #777

Merged

bumi closed this Apr 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connectors): add raspiblitz #683

feat(connectors): add raspiblitz #683

secondl1ght commented Mar 12, 2022 •

edited

Loading

secondl1ght commented Mar 12, 2022

escapedcat commented Mar 12, 2022

secondl1ght commented Mar 12, 2022

escapedcat commented Mar 12, 2022 •

edited

Loading

secondl1ght commented Mar 18, 2022

MoritzKa commented Mar 18, 2022

bumi commented Mar 18, 2022

MoritzKa commented Mar 18, 2022

bumi commented Mar 18, 2022

secondl1ght commented Mar 18, 2022

MoritzKa commented Mar 18, 2022

secondl1ght commented Mar 21, 2022

secondl1ght commented Apr 2, 2022

secondl1ght commented Apr 5, 2022

feat(connectors): add raspiblitz #683

feat(connectors): add raspiblitz #683

Conversation

secondl1ght commented Mar 12, 2022 • edited Loading

Link this PR to an issue

Type of change

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

How Has This Been Tested?

Checklist:

secondl1ght commented Mar 12, 2022

escapedcat commented Mar 12, 2022

secondl1ght commented Mar 12, 2022

escapedcat commented Mar 12, 2022 • edited Loading

secondl1ght commented Mar 18, 2022

MoritzKa commented Mar 18, 2022

bumi commented Mar 18, 2022

MoritzKa commented Mar 18, 2022

bumi commented Mar 18, 2022

secondl1ght commented Mar 18, 2022

MoritzKa commented Mar 18, 2022

secondl1ght commented Mar 21, 2022

secondl1ght commented Apr 2, 2022

secondl1ght commented Apr 5, 2022

secondl1ght commented Mar 12, 2022 •

edited

Loading

escapedcat commented Mar 12, 2022 •

edited

Loading