Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RaspiBlitz #777

Merged
merged 24 commits into from
Apr 21, 2022
Merged

feat: add RaspiBlitz #777

merged 24 commits into from
Apr 21, 2022

Conversation

secondl1ght
Copy link
Contributor

@secondl1ght secondl1ght commented Apr 5, 2022 •
edited
Loading

New PR for #683 due to merge conflicts.

Closes #683 #673

@secondl1ght
feat(connectors): add raspiblitz
26d9f05
@secondl1ght
feat: add instructions
da20da1
@secondl1ght
Merge branch 'master' into add-raspiblitz
ae0fd7a
@secondl1ght
Merge branch 'getAlby:master' into add-raspiblitz
75d88e1
@secondl1ght
refactor: remove upload macaroon, update port, update textfield
f339b51
@secondl1ght
feat: add https and port for user automatically
6128c80
@secondl1ght
Merge branch 'getAlby:master' into add-raspiblitz
3690ccf
@secondl1ght
fix: update input pattern regex and message, add conditional to onChange
e219b94
@secondl1ght
Merge branch 'master' into add-raspiblitz
142dcee
@secondl1ght
fix: change URL references to .onion address
150a8f0
@secondl1ght
Merge branch 'add-raspiblitz' of github.com:secondl1ght/lightning-bro…
87e065a 
…wser-extension into add-raspiblitz
@secondl1ght
refactor: make 2 functions for change and remove onion validation
0354139
@secondl1ght
Merge branch 'getAlby:master' into add-raspiblitz
dbce16e
@secondl1ght
refactor: make port configurable
ff06931
@secondl1ght
feat: check for http and add if not present
d7f1aac
@secondl1ght
refactor: use bumi suggestion to dry handleUrl function
206d1f7
@secondl1ght
Merge branch 'add-raspiblitz' of https://github.com/secondl1ght/light…
f256fd9 
…ning-browser-extension into secondl1ght-add-raspiblitz
@secondl1ght
fix: add raspiblitz back in after merge
3a819ad
@secondl1ght
fix: delete unused code
304eb52
@secondl1ght
fix: filepath
e9a41f4
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Build files:

@secondl1ght secondl1ght mentioned this pull request Apr 5, 2022
Closed
7 tasks
@secondl1ght secondl1ght requested a review from bumi April 5, 2022 21:21
@secondl1ght secondl1ght self-assigned this Apr 5, 2022
@secondl1ght secondl1ght requested a review from MoritzKa April 10, 2022 02:12
bumi
bumi requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look in detail, but I think this is not following the new connector screen refactorings:

https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/screens/connectors/ConnectMyNode/index.tsx#L91-L92

src/app/screens/connectors/ConnectRaspiBlitz/index.tsx Outdated Show resolved Hide resolved
@secondl1ght
Copy link
Contributor Author

I did not look in detail, but I think this is not following the new connector screen refactorings:

https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/screens/connectors/ConnectMyNode/index.tsx#L91-L92

Ok I updated this to use the new ConnectorForm component. Thanks for pointing that out I didn't notice we had a new component for this.

bumi
bumi reviewed Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, great. did you test it? did you also try to type the URL manually?

@MoritzKa can you test again?

@secondl1ght
Copy link
Contributor Author

ok, great. did you test it? did you also try to type the URL manually?

@MoritzKa can you test again?

Yep I tested it and was able to connect an LND node coming from Polar, I tried typing http and leaving it empty and it worked both times.

@bumi
Copy link
Collaborator

bumi commented Apr 14, 2022

great,thanks!

@MoritzKa
Copy link
Contributor

ACK
https://onion_address works
onion_address works
http://onion_address does not work

@bumi
Copy link
Collaborator

bumi commented Apr 21, 2022

what does that mean?
should the http:// address work? what means it does not work? what's the error?

@MoritzKa
Copy link
Contributor

for me http:// does not need to work in order to merge this PR.
I am reporting this because sendl1ght mention above that he "tried typing http and leaving it empty and it worked both times." I guess he meant https
I think the error message was "you are trying to call a HTTPS URI from a HTTP client"

bumi
bumi approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@bumi bumi merged commit e198596 into master Apr 21, 2022
@bumi bumi deleted the secondl1ght-add-raspiblitz branch April 21, 2022 19:55
@bumi
Copy link
Collaborator

bumi commented Apr 22, 2022

@secondl1ght can you make a PR with those updated import paths?

@secondl1ght
Copy link
Contributor Author

Ok @dylancom is this a new way we are doing imports?

@secondl1ght secondl1ght mentioned this pull request Apr 22, 2022
Merged
3 tasks
@bumi
Copy link
Collaborator

bumi commented Apr 22, 2022

Ok @dylancom is this a new way we are doing imports?

#798

bumi added a commit to umarrg/lightning-browser-extension that referenced this pull request Apr 23, 2022
@bumi
Merge branch 'master' into website-screen
b5bf8cb 
# By Dylan Companjen (3) and others
# Via GitHub (4) and secondl1ght (1)
* master:
  refactor: imports
  feat: add RaspiBlitz (getAlby#777)
  feat: theme selector (getAlby#786)
  chore: cross-env can handle multiple envs at once
  feat: add screens & components aliases
  feat: add ~ as a root import alias
  Update webpack-dev-server to version 4.8.1
  refactor checkInvoice
  feat(send): support BIP21 URI with BOLT 11 invoice QRCode

# Conflicts:
#	src/app/screens/Publishers.tsx
#	tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylancom dylancom dylancom left review comments

@bumi bumi bumi approved these changes

@MoritzKa MoritzKa Awaiting requested review from MoritzKa

Assignees

@secondl1ght secondl1ght

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@secondl1ght @bumi @MoritzKa @dylancom