Add django-oscar for mapping and benchmarking #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --start-page to print_pulls.py to make it easier to restart the process if you previously aborted it.
Add --id-filter, --version-filter, and --keep to engine_validation.py. Using these makes it easier to debug validation of a small subset of instances.
Call out tests that ERRORed before and after patch application for an instance. These may indicate a problem with the way the environment has been configured.
refactor: fix a typo fix: don't assume particular dataset splits Don't assume that a dataset has "test" and "dev" splits. Iterate over all splits when looking for an instance. feat: add django-oscar dataset fix: run custom hook during install Give a repo configuration the chance to run a hook between environment creation and installing dependencies. Use it to set up django-oscar so uWSGI installs correctly.
The "created_at" attribute of a prediction is a Timestamp, make sure it serializes correctly.
When loading data for solving, check to see if the given dataset name exists on disk and load it if it does. This allows the same path to be passed to solve.py and run_evaluation.py.
The django-oscar dataset has PASS_TO_PASS and FAIL_TO_PASS that are lists, rather than strings.
Update the scripts that take --verbose as a switch, changing the action from "store_true" to "count". Change a couple of checks to take advantage of the change, printing more output when --verbose is specified multiple times. In particular, only tee test command output if --verbose has been given more than once. This also restores test timeout if --verbose is only given once, or not at all.
Fix the way pytest is invoked so that --test-group-count and --test-group only get specified once.
Add a config for django-oscar with some exclusions, so mapping will run a little faster. Tell the solver about some django-oscar runs.
Update the GH action to allow the set of instances to be specified when the workflow is run.
apotterri
force-pushed
the
django-oscar_20240611
branch
5 times, most recently
from
20a96fe
to
5f743a4
Compare
Add --id_filter, --version_filter, and --show_only to make it easier to create AppMaps for a subset of instances.
Remove appmap/__init__.py so python doesn't see it as a module that can be imported. It's not ever imported, and making it a module breaks the python agent (which also has an "appmap" module).
apotterri
force-pushed
the
django-oscar_20240611
branch
from
5f743a4
to
b3f2b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, made some minor fixes/changes along the way, including restoring the timeout when running test commands.