Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(rrweb): allow multi touch gestures to be shown for mobile replays #190

Merged
merged 28 commits into from
May 31, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented May 16, 2024

looks like this with fake test data:

Screen.Recording.2024-05-16.at.6.32.53.PM.mov

closes getsentry/sentry#70588

@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from d66f8bb to 5f4dfd3 Compare May 16, 2024 13:21
@michellewzhang michellewzhang marked this pull request as draft May 16, 2024 13:23
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from ab233e2 to 94e7595 Compare May 16, 2024 14:26
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from d5a356e to d87bbb9 Compare May 16, 2024 14:30
package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from 7a44522 to 673d62a Compare May 16, 2024 14:58
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from 42ba76c to c92bc1b Compare May 16, 2024 15:32
@michellewzhang michellewzhang requested a review from billyvg May 16, 2024 15:54
@@ -1085,10 +1131,17 @@ export class Replayer {
}
case IncrementalSource.Drag:
case IncrementalSource.TouchMove:
case IncrementalSource.MouseMove:
case IncrementalSource.MouseMove: {
const pointerId =
Copy link
Member Author

@michellewzhang michellewzhang May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is assuming we adjust the data type to

// mousemoveData
{
    "type": 3,
    "timestamp": 1713999610580,
    "data": {
        "source":  IncrementalSource.TouchMove,
        "positions": [{
          "id": 0,
          "x": 149.436,
          "y": 433.929,
        },
       {
          "id": 1,
          "x": 243.436,
          "y": 155.929,
        }],
        "pointerType": 2
        "pointerId": 2,
    }
}

@michellewzhang michellewzhang marked this pull request as ready for review May 16, 2024 16:36
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from 405f226 to 07d1d67 Compare May 28, 2024 19:13
@michellewzhang michellewzhang requested a review from billyvg May 28, 2024 19:18
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
billyvg

This comment was marked as resolved.

@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from 99b4c57 to fbb92f6 Compare May 29, 2024 16:58
@michellewzhang michellewzhang requested a review from billyvg May 29, 2024 23:52
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/replay/index.ts Show resolved Hide resolved
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch 2 times, most recently from a3d310b to e1af343 Compare May 30, 2024 23:38
@michellewzhang michellewzhang force-pushed the mz/rrweb-ref-multi-gesture branch from e1af343 to 56ed9a0 Compare May 30, 2024 23:42
@michellewzhang michellewzhang requested a review from billyvg May 30, 2024 23:44
@bruno-garcia
Copy link
Member

I imagined with multi touch we'd see two circles in parallel, representing two fingers. Is that possible?

@michellewzhang
Copy link
Member Author

michellewzhang commented May 31, 2024

I imagined with multi touch we'd see two circles in parallel, representing two fingers. Is that possible?

@bruno-garcia yeah definitely - the demo video in the description is just some fake data i made up, what it will actually look like is just rendering exactly what the sdk sends us in terms of x/y positions. so we will mirror exactly what touches the user is doing

packages/rrweb/test/replayer.test.ts Outdated Show resolved Hide resolved
packages/rrweb/test/replayer.test.ts Outdated Show resolved Hide resolved
@michellewzhang michellewzhang merged commit fe5cfe2 into sentry-v2 May 31, 2024
14 checks passed
@michellewzhang michellewzhang deleted the mz/rrweb-ref-multi-gesture branch May 31, 2024 20:37
michellewzhang added a commit to getsentry/sentry that referenced this pull request Jun 4, 2024
…mp rrweb version (#71875)

see getsentry/rrweb#190

we don't need this snippet anymore because we'll create pointers lazily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Replay Details] Support multi gestures
3 participants