-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(rrweb): allow multi touch gestures to be shown for mobile replays #190
Conversation
d66f8bb
to
5f4dfd3
Compare
ab233e2
to
94e7595
Compare
d5a356e
to
d87bbb9
Compare
7a44522
to
673d62a
Compare
42ba76c
to
c92bc1b
Compare
packages/rrweb/src/replay/index.ts
Outdated
@@ -1085,10 +1131,17 @@ export class Replayer { | |||
} | |||
case IncrementalSource.Drag: | |||
case IncrementalSource.TouchMove: | |||
case IncrementalSource.MouseMove: | |||
case IncrementalSource.MouseMove: { | |||
const pointerId = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is assuming we adjust the data type to
// mousemoveData
{
"type": 3,
"timestamp": 1713999610580,
"data": {
"source": IncrementalSource.TouchMove,
"positions": [{
"id": 0,
"x": 149.436,
"y": 433.929,
},
{
"id": 1,
"x": 243.436,
"y": 155.929,
}],
"pointerType": 2
"pointerId": 2,
}
}
405f226
to
07d1d67
Compare
99b4c57
to
fbb92f6
Compare
a3d310b
to
e1af343
Compare
e1af343
to
56ed9a0
Compare
I imagined with multi touch we'd see two circles in parallel, representing two fingers. Is that possible? |
@bruno-garcia yeah definitely - the demo video in the description is just some fake data i made up, what it will actually look like is just rendering exactly what the sdk sends us in terms of x/y positions. so we will mirror exactly what touches the user is doing |
…mp rrweb version (#71875) see getsentry/rrweb#190 we don't need this snippet anymore because we'll create pointers lazily.
looks like this with fake test data:
Screen.Recording.2024-05-16.at.6.32.53.PM.mov
closes getsentry/sentry#70588