Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): Use full path for Kafka container #28724

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Sep 21, 2021

Follow up to #28574.

When we upgraded the kafka and zookeeper images we use, we did not update the volume to
use the full path (as the instructions indicate), thus, started to see this error:

Command [/usr/local/bin/dub path /var/lib/kafka/data writable] FAILED !

This change adds the full path.

When we [upgraded the kafka and zookeeper images we use][1], we did not update the volume to
use the full path (as the [instructions indicate][2]), thus, started to see this error:

>  Command [/usr/local/bin/dub path /var/lib/kafka/data writable] FAILED !

This change adds the full path.

[1]: #28574
[2]: https://docs.confluent.io/platform/current/installation/docker/operations/external-volumes.html#data-volumes-for-kafka-and-zk
@armenzg armenzg added the Component: Developer Environment This covers issues related to setting up a developer's environment label Sep 21, 2021
@armenzg armenzg self-assigned this Sep 21, 2021
@armenzg armenzg added this to the Apple M1 devservices support milestone Sep 21, 2021
@armenzg
Copy link
Member Author

armenzg commented Sep 21, 2021

Hi @avgupta456 would you mind verifying that this is fixed? It seems so from my inspecting. Thanks!

Outside of sentry devservices, the issue you reported can be demonstrated by running these (using -v /var/lib/kafka/data fixes it):

docker run \
  --net=host \
  -e ZOOKEEPER_TICK_TIME=2000 \
  -e ZOOKEEPER_CLIENT_PORT=32181 \
  -v /var/lib/zookeeper/data \
  -v /var/lib/zookeeper/log \
  confluentinc/cp-zookeeper:6.2.0

docker run \
  --net=host \
  -e KAFKA_ZOOKEEPER_CONNECT=localhost:32181 \
  -e KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://localhost:39092 \
  -v /var/lib/kafka \
  confluentinc/cp-kafka:6.2.0

@armenzg armenzg marked this pull request as ready for review September 21, 2021 16:01
@armenzg armenzg merged commit 9ddd9d0 into master Sep 21, 2021
@armenzg armenzg deleted the armenzg/dev/kafka-zookeeper-fix branch September 21, 2021 16:04
@avgupta456
Copy link

Hi @avgupta456 would you mind verifying that this is fixed? It seems so from my inspecting. Thanks!

Outside of sentry devservices, the issue you reported can be demonstrated by running these (using -v /var/lib/kafka/data fixes it):

docker run \
  --net=host \
  -e ZOOKEEPER_TICK_TIME=2000 \
  -e ZOOKEEPER_CLIENT_PORT=32181 \
  -v /var/lib/zookeeper/data \
  -v /var/lib/zookeeper/log \
  confluentinc/cp-zookeeper:6.2.0

docker run \
  --net=host \
  -e KAFKA_ZOOKEEPER_CONNECT=localhost:32181 \
  -e KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://localhost:39092 \
  -v /var/lib/kafka \
  confluentinc/cp-kafka:6.2.0

It works, thanks!

@relaxolotl
Copy link
Contributor

Heads up, it looks like the description is pointing to #28714 which is a symbolicator-related PR. Did you mean to reference #28574?

@armenzg
Copy link
Member Author

armenzg commented Sep 22, 2021

Heads up, it looks like the description is pointing to #28714 which is a symbolicator-related PR. Did you mean to reference #28574?

Thank you! You're right. I updated the comment.

armenzg added a commit that referenced this pull request Oct 4, 2021
…28574)" (#28672)

This reverts commit b4bfb00.

Originally (see [originally reported issue](#28574 (comment))), instead of reverting my change, I landed a fix that only seems to work on Apple M1 (see fix #28724). Nevertheless, It seems that the *Intel* images would still fail with the same error (see issue #29022) with:
> Command [/usr/local/bin/dub path /var/lib/kafka/data writable] FAILED !

Let's revert it and I will try again later.

Fixes #29022
armenzg added a commit that referenced this pull request Oct 6, 2021
This reverts commit 9ddd9d0.

This should have been reverted at the same time as #28672
armenzg added a commit that referenced this pull request Oct 6, 2021
This reverts commit 9ddd9d0.

This should have been reverted at the same time as #28672
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Developer Environment This covers issues related to setting up a developer's environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants