-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack integration for Sentry on private domains. #81902
base: master
Are you sure you want to change the base?
Conversation
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@cathteng I apologize for the mention, but this PR stuck for several weeks. I'm unsure who to ask for review. Given your approval of the previous Slack-related PR, would you be able to review this one, or perhaps suggest someone who could? |
Hi @wolandspb , the developer docs mention you can set the redirect link on the Slack side https://develop.sentry.dev/integrations/slack/, does this work for you? On self-hosted you'll need to create your own Slack app |
Sentry isn't finding the redirect URL on the slack side because it doesn't match the system.url-prefix. I've already tested this. |
I think I'm missing some context. When we test self-hosted locally we use |
Sorry, I could have explained this better in the PR description. |
If Sentry is behind private domain, it's impossible to set up slack integration. This PR should fix it by adding
slack.url-prefix
option, allowed you to use external domain to set up slack integration.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.