Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit(data-secrecy): Remove "detail" from delete response #82754

Merged
merged 1 commit into from
Dec 31, 2024
Merged

nit(data-secrecy): Remove "detail" from delete response #82754

merged 1 commit into from
Dec 31, 2024

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi commented Dec 31, 2024 •
edited
Loading

was tinkering with data secrecy and saw that when deleting a waiver, i get the following error:

02:38:26 server             | DELETE 204 /api/0/organizations/california/data-secrecy/ HTTP/1.1 1742
02:38:26 webpack            | <e> [webpack-dev-server] [HPM] Error occurred while proxying request dev.getsentry.net:8000/api/0/organizations/california/data-secrecy/ to http://127.0.0.1:8001/ [HPE_INVALID_CONSTANT] (https://nodejs.org/api/errors.html#errors_common_system_errors)

and after some googling, ran into postmanlabs/postman-app-support#2418 - which suggests adding "detail" is causing us to add the contentType header that the http parser doesn't like.

this seems to be the backend portion of the long lasting data secrecy bug i have been trying to track down.

@iamrajjoshi iamrajjoshi self-assigned this Dec 31, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 31, 2024
@iamrajjoshi iamrajjoshi mentioned this pull request Dec 31, 2024
Merged
@iamrajjoshi iamrajjoshi marked this pull request as ready for review December 31, 2024 16:08
@iamrajjoshi iamrajjoshi requested a review from a team as a code owner December 31, 2024 16:08
cathteng
cathteng approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably because 204 should have no content. nice!

@iamrajjoshi iamrajjoshi merged commit f1296e8 into master Dec 31, 2024
51 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/ds-waiver-cleanup branch December 31, 2024 16:27
andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
@iamrajjoshi @andrewshie-sentry
nit(data-secrecy): Remove "detail" from delete response (#82754)
e0505cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathteng cathteng cathteng approved these changes

Assignees

@iamrajjoshi iamrajjoshi

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrajjoshi @cathteng