Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump monerod version to v0.18.3.4 #1808

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

colder-is-better
Copy link
Contributor

No description provided.

@getumbrel getumbrel deleted a comment from github-actions bot Nov 20, 2024
@nmfretz
Copy link
Contributor

nmfretz commented Nov 20, 2024

Thanks for this update @colder-is-better! Sorry for the delay in reviewing this while we had our heads down on the recent umbrelOS beta release.

FYI, the monerod service must have a restart policy of "unless-stopped" in order for the daemon to start back up automatically when it is "restarted" from the UI in Advanced Settings. Without this, when a user goes to change their monero config in Advanced Settings and clicks "Save and restart monero node", their node would not actually come back online. I have changed it back here 74964e8.

I have tested a fresh install and update and everything is working well. I also added some release notes:

image

@nmfretz nmfretz merged commit 69f04e5 into getumbrel:master Nov 20, 2024
1 check passed
@colder-is-better
Copy link
Contributor Author

Thanks for this update @colder-is-better! Sorry for the delay in reviewing this while we had our heads down on the recent umbrelOS beta release.

Hey, no problem -- that was a quick review on my book!

FYI, the monerod service must have a restart policy of "unless-stopped" in order for the daemon to start back up automatically when it is "restarted" from the UI in Advanced Settings. Without this, when a user goes to change their monero config in Advanced Settings and clicks "Save and restart monero node", their node would not actually come back online. I have changed it back here 74964e8.

I already managed to bump into this issue, and I was scratching my head trying to figure out what happened. Thanks for fixing and clarifying this!

I have tested a fresh install and update and everything is working well. I also added some release notes:

Very nice. From now on, I'll be sure to add those myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants