Add support for Phi-3.5-vision-instruct #9209
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Phi-3.5-vison-instruct
The biggest challenge here was porting over the
hd_transform
that's performed on the image embeddings before the projector. This requires doing a 6d reshape-permute which I had to adapt to work with a series of 4d reshape-permutes. It looks like a mess but it does work (I tested this section against numpy).Converted GGUFs can be found here
Prompt format
Update
Just realised this still needs work to implement the hd transform in the preprocessing steps as well, will keep it as a draft for now.