Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: fix regression: asking for deprecated autoAddOpenGLRunpath #9220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nix: fix regression: asking for deprecated autoAddOpenGLRunpath #9220

wants to merge 2 commits into from

Conversation

SomeoneSerge
Copy link
Collaborator

@SomeoneSerge SomeoneSerge added the nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment label Aug 28, 2024
@github-actions github-actions bot added the devops improvements to build systems and github actions label Aug 28, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Aug 30, 2024
@slaren
Copy link
Collaborator

slaren commented Aug 30, 2024 •
edited
Loading

Note that the MPI backend was removed a while ago in #7395. I removed the line of the nix build file that sets the LLAMA_MPI option (cmakeBool "LLAMA_MPI" useMpi), but probably all the other references to MPI should be removed as well, or replaced with the RPC backend.

@SomeoneSerge
Copy link
Collaborator Author

Oh! That is a rather confusing state of affairs then, we really should have deleted the attribute in, afaict, NixOS/nixpkgs#313525. I'll push a commit a bit later. Thanks

@Green-Sky Green-Sky mentioned this pull request Aug 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
devops improvements to build systems and github actions nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SomeoneSerge @slaren @mofosyne