Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersonioClientV1: paging fixes, workarounds and calendar damage repair #207

Merged
merged 1 commit into from
Oct 27, 2024
Merged

PersonioClientV1: paging fixes, workarounds and calendar damage repair #207

merged 1 commit into from
Oct 27, 2024

Conversation

lyind
Copy link
Contributor

@lyind lyind commented Oct 22, 2024

Towards https://github.com/giantswarm/giantswarm/issues/31938

Summary

This PR

  • further improves the recently modified paging logic
  • works around Personio API's paging inconsistencies:
    grafik
    grafik
  • adds recovery (undelete) routines to cleanup the damage from (test-)running the syncTimeOffs() version with broken paging

Note:
Has already been tested and run, cleanup completed (hopefully).

@lyind lyind requested a review from pipo02mix October 22, 2024 21:31
@lyind lyind self-assigned this Oct 22, 2024
@lyind lyind requested a review from a team as a code owner October 22, 2024 21:31
@lyind lyind merged commit 20c3b31 into main Oct 27, 2024
6 checks passed
@lyind lyind deleted the personio-api-fixes branch October 27, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipo02mix pipo02mix pipo02mix approved these changes

Assignees

@lyind lyind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyind @pipo02mix