Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete logical switch port first when cleanup the pod #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cathy-zhou
Copy link

Today, when a Pod is deleted, its logical switch port is only deleted if
the port is in the logicalPortCache. We need to delete Pods' logical
switch ports regardless to avoid stale logical entities.

Signed-off-by: Yun Zhou [email protected]

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Today, when a Pod is deleted, its logical switch port is only deleted if
the port is in the logicalPortCache. We need to delete Pods' logical
switch ports regardless to avoid stale logical entities.

Signed-off-by: Yun Zhou <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 188971117

  • 4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 58.362%

Changes Missing Coverage Covered Lines Changed/Added Lines %
go-controller/pkg/ovn/pods.go 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
go-controller/pkg/ovn/pods.go 1 68.11%
Totals Coverage Status
Change from base Build 188965966: 0.1%
Covered Lines: 5367
Relevant Lines: 9196

💛 - Coveralls

@girishmg girishmg force-pushed the master branch 3 times, most recently from 4d44be0 to 5044c18 Compare May 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants