Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode website static assets bucket name in Pulumi #10968

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Nov 23, 2022

There are currently two buckets on S3, the new one, bucket-fc46b51, deployed Nov 11. The app is currently mis-configured to upload assets to the new bucket, but the CloudFront CDN still points to the old bucket
bucket-0427bb4. This hardcodes the app to point to the old bucket, which has had assets synced from the new one.

@@ -72,6 +72,7 @@ const staticAssetsBucket = new aws.s3.Bucket("bucket", {
website: {
indexDocument: "index.html",
},
bucket: "bucket-0427bb4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be better to but this hard coding in the environment variables section. Just would ensure that it goes to what we want exactly for the time being.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Gerald said while we were pairing that he's gonna change this section later anyway, so if you don't mind could we merge this as-is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I can approve this as a hot-fix to get the issue resolved now, but we need to make sure to follow-up on this and properly resolve it.
Not sure who will pick up the responsibility of properly fixing this. But I will make an issue in GH for myself as a reminder, and we can follow-up on that @kammerdiener

Copy link
Contributor

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for a hotfix, but we need somebody to implement a proper fix for this issue ASAP.

@nutrina
Copy link
Contributor

nutrina commented Nov 24, 2022

@kammerdiener have created this issue in GH related to getting a proper fix: #10969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants