Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regions in image viewer #10

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

jfoster17
Copy link
Member

Add Scatter Region to Image Viewer

Description

This is the companion PR to glue-viz/glue#2456 that provides the UI to configure a ScatterRegionLayer as well as tests for this new functionality.

@jfoster17 jfoster17 marked this pull request as ready for review November 1, 2023 17:51
@jfoster17 jfoster17 force-pushed the support-regions-in-imageviewer branch from 2565b2e to 6976575 Compare November 14, 2023 17:02
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me provided that the CI passes!

@jfoster17
Copy link
Member Author

The only non-allowed failures now are on the dev tests because of this error with pvextractor and the latest dev versions of astropy.

@astrofrog
Copy link
Member

Perfect, thanks!

@astrofrog astrofrog merged commit 7b68fcc into glue-viz:main Nov 15, 2023
26 of 34 checks passed
@astrofrog astrofrog added the enhancement New feature or request label Nov 15, 2023
@astrofrog astrofrog changed the title Support regions in imageviewer Support regions in image viewer Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants