Out of memory on missing quote fixes #31

gobuffalo · Jan 10, 2018 · 66309e4 · 66309e4
1 parent 3d4efd2
commit 66309e4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lexer/lexer.go b/lexer/lexer.go
@@ -207,6 +207,10 @@ func (l *Lexer) nextInsideToken() token.Token {
 }
 
 func (l *Lexer) skipWhitespace() {
+	if l.readPosition >= len(l.input) {
+		l.readChar()
+		return
+	}
 	for l.ch == ' ' || l.ch == '\t' || l.ch == '\n' || l.ch == '\r' {
 		l.readChar()
 	}
@@ -226,6 +230,7 @@ func (l *Lexer) readChar() {
 }
 
 func (l *Lexer) peekChar() byte {
+
 	if l.readPosition >= len(l.input) {
 		return 0
 	}

diff --git a/plush_test.go b/plush_test.go
@@ -457,6 +457,15 @@ func Test_MissingQuote(t *testing.T) {
 	r.Error(err)
 }
 
+func Test_MissingQuote_Variant(t *testing.T) {
+	r := require.New(t)
+	input := `<%= foo("test) %>".`
+	ctx := NewContext()
+	ctx.Set("foo", func(string) {})
+	_, err := Render(input, ctx)
+	r.Error(err)
+}
+
 func Test_RunScript(t *testing.T) {
 	r := require.New(t)
 	bb := &bytes.Buffer{}