Assorted dependency updates #52
Conversation
These updates fix building the project on my up to date Linux box due to missing cstdint headers on the older Draco versions it was pinned to, and bumps Conan 1.x to the latest semver-compatible release, which also introduces support for newer GCC compilers. While at it, I've also bumped the GitHub Actions checkout version tag to v4, from v3, and the runner image versions. The Ubuntu runner version was purposefully not updated to avoid the risk of making binaries less portable than before due to a bump in the `glibc` version that the compiler will link to.
|
Updates to the github actions for (conan2)system are welcome but step by step is how I would approach it. |
Great to hear that! I agree with taking things step by step. That seems important, especially considering the issues with Windows builds that have cropped up... 😂 I've been delving into the Windows build failure, and it seems to stem from CMake generating build instructions that output the FBX2glTF library artifact to a file matching the input .lib. I'm not entirely certain why updating dependencies triggered this change in behavior (from the tests I conducted, it seems unrelated to the Conan and MSVC versions), but I've fixed it in the latest commit by renaming the library target to something else. I believe such change does not have any adverse effects on the generated builds. The commit worked smoothly in other CI runs on my fork, so let's see how it fares here 🙏 |
|
I am currently outside so probably can review later next week. However the github actions passed. |
|
Thanks |
These updates fix building the project on my up to date Linux box due to missing cstdint headers on the older Draco versions it was pinned to, and bumps Conan 1.x to the latest semver-compatible release, which also introduces support for newer GCC compilers.
While at it, I've also bumped the GitHub Actions checkout version tag to v4, from v3, and the runner image versions. The Ubuntu runner version was purposefully not updated to avoid the risk of making binaries less portable than before due to a bump in the
glibcversion that the compiler will link to.I've also considered updating the project to Conan 2, but that seemed a bit delicate, so I didn't want to delve into such a task just yet. Let me know if that'd be a welcome change, and if so I can see if I can spend some time figuring that out!