Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write buffers section if buffer is empty #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danwillm
Copy link

@danwillm danwillm commented Jul 1, 2024

I have an fbx file that when procced through FBX2gLTF produced the buffers json segment as:

"buffers": [
{
"byteLength": 0
}
],

Which is not valid in gltf. Instead, omit this from being written to the file by only writing non-empty json.

@danwillm
Copy link
Author

Hey, anything else you'd like me to resolve for this to be merged?

@fire
Copy link
Member

fire commented Jul 31, 2024

I haven't had much testing of this since in Godot 4.3 we switched to ufbx. I'll merge and it'll generate builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants