feat: attribute filter with secondary label #5033
Conversation
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20900/ finished with 'FAILURE' status. |
| @@ -46,13 +46,16 @@ const commonGroupableCatalogItemModifications = | |||
| const tigerLabelToDisplayFormMd = ( | |||
| label: JsonApiLabelOutWithLinks, | |||
| attributeRef: ObjRef, | |||
| defaultLabelId?: string, | |||
There was a problem hiding this comment.
When this can be undefined? It's only for backward compatibility?
There was a problem hiding this comment.
the same convertor is used also for geoLabels manipulation and there the default is not provided as it is not relevant
|
|
||
| function generateLocalId(prefix: string, objRef: ObjRef, inObject: IAttributeElements): string { | ||
| const hasher = new SparkMD5(); | ||
| hasher.append(JSON.stringify(inObject)); |
There was a problem hiding this comment.
Not sure if safe stringify should not be used. Probably not entirely necessary here?
import stringify from "json-stable-stringify";
There was a problem hiding this comment.
I used same code as for generating other missing localIdentifiers, eg. libs/sdk-model/src/execution/measure/factory.ts
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20901/ finished with 'FAILURE' status. |
|
ok to test |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20903/ finished with 'FAILURE' status. |
ivan-nejezchleb
force-pushed
the
ine-lx-183
branch
from
6ce99d3
to
356fb86
Compare
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20904/ finished with 'SUCCESS' status. |
|
extended test - backstop |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2200/ finished with 'UNSTABLE' status. |
ivan-nejezchleb
force-pushed
the
ine-lx-183
branch
from
356fb86
to
d29b0db
Compare
|
extended test - backstop |
ivan-nejezchleb
force-pushed
the
ine-lx-183
branch
from
d29b0db
to
6b86d2b
Compare
|
extended test - tiger-cypress - isolated |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20906/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2202/ finished with 'UNSTABLE' status. |
|
extended test - tiger-cypress - isolated |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20907/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2203/ finished with 'UNSTABLE' status. |
- secondary label does not affect execution anymore - primary label is always used for execution - secondary label is stored outside of filter for UI only - each AF in Insight has now localIdentifier - secondary label references Af via localId - displayForms now contain isPrimary, isDefault flags - AF keeps its selection when secondary label switched - change of secondary label does not recreate AF handler - collectLabelElements can now filter by primary label JIRA: LX-183 risk: high
JIRA: LX-183 risk: low
- fix FF propagation - update test snapshots JIRA: LX-183 risk: low
JIRA: LX-183 risk: low
ivan-nejezchleb
force-pushed
the
ine-lx-183
branch
from
05c50d8
to
0b32771
Compare
|
extended test - tiger-cypress - isolated |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20910/ finished with 'SUCCESS' status. |
|
extended test - tiger-cypress - integrated |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2205/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-compatibility-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-compatibility-pipeline/801/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline/2072/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20911/ finished with 'SUCCESS' status. |
JIRA: LX-183
risk: high
Important
Please, don't forget to run
rush changefor the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: