Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong world vector range in training loss calculation #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathansalzer
Copy link

@jonathansalzer jonathansalzer commented Jul 22, 2024

Throughout training and inference, a world vector range of (-2; 2) is consistently used. However, during loss calculation, the world vector range is not explicitly passed to the action tokenization function, causing it to default to a range of (-1; 1). This mismatch leads to scaling issues: values are doubled, as well as clipped if they exceed the range (-1; 1).

By passing the model world vector range to the action tokenization, this issue is resolved.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this due to the poor performance of the trained model when tested. But it's solved now, took days to debug 😂😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants