-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement calculated-expression extension #1380
Conversation
@RaaziaTarique kindly take a 1st pass review |
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
=============================================
+ Coverage 0 32.61% +32.61%
- Complexity 0 320 +320
=============================================
Files 0 151 +151
Lines 0 5273 +5273
Branches 0 942 +942
=============================================
+ Hits 0 1720 +1720
- Misses 0 3307 +3307
- Partials 0 246 +246
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…into 971_calc_exp
…into 971_calc_exp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt
Outdated
Show resolved
Hide resolved
@jingtang10 I have found few libraries for graph generation. I am still exploring these and if its possible to use any for our expression dependency graph |
Thanks Maimoona - what I had in mind was just to use a basic data structure to represent the dependencies. I wasn't sure that we'd need to use any external libraries for this. We already have some auxiliary data strcuture such as the parent map in the view model - this would be similar to that I thought. |
@maimoonak i turned on auto-merge. so if you update the branch it should merge automatically. thanks |
Head branch was pushed to by a user without write access
* Implement calculated-expression extension * Fix form value update bug * Detect cyclic dependency | fix on init value loading * Fix merge conflict * Make birthdate age dependent | Handle and fix quantity values * Fix failing test * quantity viewholder delegate test covergae * Test coverage for update flow * spotless fix * spotless fix | re-run ci * Test covergae for questionnaire fragment * test coverage for quantity types * questionnaire fragment test with launchInFragmentContainer * Update datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt Co-authored-by: aditya-07 <[email protected]> * Move widget to LayoutList | Run Calculation after state-change * Revert the run-expression after state-flow * remove empty line changes * spotless fix * Esperesso test | Fix failing test * Remove unnessary changes * Fix espresso tests * Ignore Failing tests * Revert ignore test | merge main | refactor * spotless fix * Rename tests * Add tests and docs * Move catalog calculation to behavior tab * spotless fix * Update datacapture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt Co-authored-by: Jing Tang <[email protected]> * Resolve feedback for naming * Resolve feedback for doc and naming * Refactor the update answer handling logic * Resolve feedback and merge master * Fix failing test Co-authored-by: aditya-07 <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Jing Tang <[email protected]>
Fixes #971 #1173
Description
Implemented the calculated expression extension. The feature also calculated cyclic dependency, and prevents the infinite calls of callback
Type
Choose one: Feature
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.