UI Component MarkdownView for code editor
#1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
nighca
force-pushed
the
issue-1106
branch
3 times, most recently
from
59866c5 to
a402b30
Compare
There was a problem hiding this comment.
Copilot reviewed 13 out of 28 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- spx-gui/package-lock.json: Language not supported
- spx-gui/package.json: Language not supported
- spx-gui/src/components/editor/code-editor/ui/DefinitionOverviewWrapper.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/MarkdownView.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/APIReference.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/DefinitionDetail.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/runtime.ts: Evaluated as low risk
- spx-gui/src/components/editor/preview/EditorPreview.vue: Evaluated as low risk
- spx-gui/src/components/editor/panels/EditorPanels.vue: Evaluated as low risk
- spx-gui/src/components/editor/panels/ConsolePanel.vue: Evaluated as low risk
- spx-gui/src/components/editor/preview/InPlaceRunner.vue: Evaluated as low risk
- spx-gui/src/components/editor/EditorContextProvider.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/CodeEditor.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/DefinitionDetailWrapper.vue: Evaluated as low risk
- spx-gui/src/components/common/markdown-vue/MarkdownView.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
spx-gui/src/components/editor/code-editor/common.ts:77
- [nitpick] The variable name overloadId is introduced without a clear explanation or context. Consider adding a comment or renaming it to something more descriptive.
overloadId?: string
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- spx-gui/package-lock.json: Language not supported
- spx-gui/package.json: Language not supported
- spx-gui/src/components/editor/code-editor/ui/APIReference.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/DefinitionDetail.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/DefinitionDetailWrapper.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/DefinitionOverviewWrapper.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/MarkdownView.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/common.ts: Evaluated as low risk
aofei
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1097.
Implement component
MarkdownView(without style), update UI ComponentMarkdownViewfor code editor #1106Draft for custom components which can be nested in markdown string
Supported components: https://github.com/goplus/builder/pull/1109/files#diff-2b45b07de42d0666a4d124e657a01578f9dee089349a62c5ab9821e1d53d4ae5R20-R41