Fixes and improvements for postgresql #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to date null values
…o missing $key variable error
| @@ -1831,7 +1831,7 @@ CREATE TABLE "#__modules" ( | |||
| "id" serial NOT NULL, | |||
| "title" character varying(100) DEFAULT '' NOT NULL, | |||
| "note" character varying(255) DEFAULT '' NOT NULL, | |||
| "content" text NOT NULL, | |||
| "content" text DEFAULT '' NOT NULL, | |||
There was a problem hiding this comment.
MySQL version hasn't default value, see here, why have you added this ?
There was a problem hiding this comment.
I must verify what is the exactly error this generated. But as I can remember, PostgreSQL is not so fair like MySQL with bad SQL.
There was a problem hiding this comment.
I tested this today and this is not necessary anymore. I think I changed this before last fix in postgresql driver. This is related to problems with null values. I will revert this.
There was a problem hiding this comment.
Ok, I'll wait your changes and then I'll merge.
Thanks!
…extensions installation is broken.
…e is protected again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gabriele,
I made a lot of improvements in postgresql driver adding support to numeric and null values in a generic way. Please, take a look and let me know if you will merge them.
Thanks.