Fixes and improvements for postgresql

installation/sql/postgresql/joomla.sql

@@ -1831,7 +1831,7 @@ CREATE TABLE "#__modules" (
   "id" serial NOT NULL,
   "title" character varying(100) DEFAULT '' NOT NULL,
   "note" character varying(255) DEFAULT '' NOT NULL,
-  "content" text NOT NULL,
+  "content" text DEFAULT '' NOT NULL,
   "ordering" bigint DEFAULT 0 NOT NULL,
   "position" character varying(50) DEFAULT '' NOT NULL,
   "checked_out" integer DEFAULT 0 NOT NULL,
@@ -1842,7 +1842,7 @@ CREATE TABLE "#__modules" (
   "module" character varying(50) DEFAULT NULL,
   "access" bigint DEFAULT 0 NOT NULL,
   "showtitle" smallint DEFAULT 1 NOT NULL,
-  "params" text NOT NULL,
+  "params" text DEFAULT '' NOT NULL,
   "client_id" smallint DEFAULT 0 NOT NULL,
   "language" character varying(7) NOT NULL,
   PRIMARY KEY ("id")

libraries/joomla/database/database/postgresql.php

@@ -447,6 +447,8 @@ public function insertid()
 	public function insertObject($table, &$object, $key = null)
 	{
 		// Initialise variables.
+		$columns = $this->getTableColumns($table);
+
 		$fields = array();
 		$values = array();
 
@@ -467,7 +469,7 @@ public function insertObject($table, &$object, $key = null)
 
 			// Prepare and sanitize the fields and values for the database query.
 			$fields[] = $this->quoteName($k);
-			$values[] = is_numeric($v) ? $v : $this->quote($v);
+			$values[] = $this->sqlValue($columns, $k, $v);
 		}
 
 		// Create the base insert statement.
@@ -1043,6 +1045,47 @@ public function replacePrefix($sql, $prefix = '#__')
 		return $replacedQuery;
 	}
 
+	/**
+	 * This function return a field value as a prepared string to be used in a SQL statement.
+	 *
+	 * @param   string  $table_fields  The table fields types returned by ::getTableColumns.
+	 * @param   string  $value         The php variable value.
+	 * 
+	 * @return  string  The quoted string.
+	 *
+	 * @since   11.3
+	 */
+	public function sqlValue($columns, $field_name, $field_value)
+	{
+		switch ($columns[$field_name]) {
+			case 'boolean':
+				if ($field_value == 't')
+				{
+					$field_value = true;
+				}
+				$val = is_bool($field_value) ? ( $field_value ? 'TRUE' : 'FALSE' ) : 'NULL';
+				break;
+			case 'bigint':
+			case 'bigserial':
+			case 'integer':
+			case 'money':
+			case 'numeric':
+			case 'real':
+			case 'smallint':
+			case 'serial':
+				$val = strlen($field_value) == 0 ? 'NULL' : $field_value;
+				break;
+			case 'date':
+				if (empty($field_value))
+				{
+					$field_value = $this->getNullDate();
+				}
+			default:
+				$val = $this->quote($field_value);
+		}
+		return $val;
+	}
+
 	/**
 	 * Method to commit a transaction.
 	 *
@@ -1154,6 +1197,8 @@ public function unlockTables()
 	public function updateObject($table, &$object, $key, $nulls = false)
 	{
 		// Initialise variables.
+		$columns = $this->getTableColumns($table);
+
 		$fields = array();
 		$where = '';
 
@@ -1174,7 +1219,8 @@ public function updateObject($table, &$object, $key, $nulls = false)
 			// Set the primary key to the WHERE clause instead of a field to update.
 			if ($k == $key)
 			{
-				$where = $this->quoteName($k) . '=' . (is_numeric($v) ? $v : $this->quote($v));
+				$key_val = $this->sqlValue($columns, $k, $v);
+				$where = $this->quoteName($k) . '=' . $key_val;
 				continue;
 			}
 
@@ -1192,10 +1238,9 @@ public function updateObject($table, &$object, $key, $nulls = false)
 					continue;
 				}
 			}
-			// The field is not null so we prep it for update.
 			else
 			{
-				$val = (is_numeric($v) ? $v : $this->quote($v));
+				$val = $this->sqlValue($columns, $k, $v);
 			}
 
 			// Add the field to be updated.

libraries/joomla/installer/adapters/component.php

@@ -541,7 +541,7 @@ public function install()
 			return false;
 		}
 
-		$eid = $row->$key;
+		$eid = $row->extension_id;
 
 		// Clobber any possible pending updates
 		$update = JTable::getInstance('update');