Enable typescript support by default #4200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkiba
requested review from
mstoykov and
inancgumus
and removed request for
a team
andrewslotin
requested review from
oleiade
and removed request for
inancgumus
mstoykov
requested changes
Jan 24, 2025
There was a problem hiding this comment.
The request changes is just so it doesn't get merged by accident.
This introduces 2 breaking changes:
- with removign experimental_enhanced as compatiblity mode it will break anyone who is using it, including any archives made with it.
- as Discussion about
globalandexperimental_enhanced#3860 explained *enhanced doesn't aliasglobaltoglobalThisand this is likely going to break even more scripts given the usage statistics we have.
Additionally as discussed in #3864 we kind of want to remove compatibility-mode now, arguably this should have never been part of it but separate option, but alas.
I would prefer if I take over this and remove the dependancy on compatibility-mode for this and just enable it by default. The question is do we add an option a kin to node to disable/enable this or is that not relevant as it only is enabled on files with .ts file extension?
|
Please go ahead. I would be happy if you would take it. |
5 tasks
|
Closing in favor of #4292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enable typescript support by default.
Why?
k6 v0.52.0 introduced experimental support for TypeScript as an opt-in feature. To enable this, users must specify
experimental_enhancedas a compatibility mode when running thek6 runcommand.After six months, this feature can now be regarded as stable and is set as the default for executing scripts. In contrast, the current default
extendedmode is available as an opt-out option.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Closes #4194