Enable type stripping by default #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
inancgumus and
joanlopez
and removed request for
a team
|
This superseeds #4200 |
joanlopez
approved these changes
Jan 28, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enable type stripping by default
Why?
Closes #4194
This does currently skip doing any cleaning in part because most of it will be intrusive but also because it will be somewhat breaking changes. Also might be completely different with #3864 and some other refactoring issues in mind, I feel like not trying to remove stuff now is better.
Additionally,
experimental_enhancedis currently just a synonym forbase. Again touching on #3864Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)