Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expert Filter] : Support StaticVarCompensator equipment type #452

Merged
merged 32 commits into from
Jun 18, 2024

Conversation

thangqp
Copy link
Contributor

@thangqp thangqp commented May 23, 2024

@thangqp thangqp changed the title [Expert Filter] : add criteria for StaticVarCompensator [Expert Filter] : Support StaticVarCompensator equipment type May 30, 2024
@Mathieu-Deharbe Mathieu-Deharbe self-requested a review June 6, 2024 14:01
@thangqp thangqp requested a review from Mathieu-Deharbe June 10, 2024 13:15
@@ -70,6 +70,29 @@ const filter_expert_en = {
voltageLevelProperty: 'Voltage level property',
voltageLevelProperty1: 'Voltage level property 1',
voltageLevelProperty2: 'Voltage level property 2',
'maxQAtNominalV.svar': 'Q max at nominal voltage',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no unit for many fields while we have units for other equipments. To discuss with PO if they want it or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two translation keys ended with suffix '.svar' in order to customize label without unit (demanded by Christelle)

Copy link
Contributor Author

@thangqp thangqp Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE! Unit are added to some label, see 6ae6cfc

fixQAtNominalV: 'Q fixe à tension nominale',
'maxSusceptance.svar': 'Susceptance max',
minSusceptance: 'Susceptance min',
svarRegulationMode: 'Mode de réglage',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RegulationMode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are ratioRegulationMode and phaseRegulationMode at line 58-59, that why I use svar as prefix for Static Var Compensator RegulationMode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE! Finally, I correct these keys as your suggestion.. see 6ae6cfc

'maxSusceptance.svar': 'Susceptance max',
minSusceptance: 'Susceptance min',
svarRegulationMode: 'Mode de réglage',
'svarRegulationMode.off': 'Arrêt',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regulationMode.off
regulationMode.reactivePower

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem, see my reply above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE! corrected in 6ae6cfc

@thangqp thangqp requested a review from etiennehomer June 12, 2024 16:57
@thangqp thangqp requested a review from Mathieu-Deharbe June 14, 2024 13:07
@thangqp thangqp requested a review from Mathieu-Deharbe June 17, 2024 13:53
@thangqp thangqp merged commit b287275 into main Jun 18, 2024
3 checks passed
@thangqp thangqp deleted the griddyna_expert_filter_svar branch June 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants