-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Expert Filter] : Support StaticVarCompensator equipment type #452
Conversation
src/components/inputs/react-query-builder/group-rule-editor/rule-value-editor.tsx
Outdated
Show resolved
Hide resolved
@@ -70,6 +70,29 @@ const filter_expert_en = { | |||
voltageLevelProperty: 'Voltage level property', | |||
voltageLevelProperty1: 'Voltage level property 1', | |||
voltageLevelProperty2: 'Voltage level property 2', | |||
'maxQAtNominalV.svar': 'Q max at nominal voltage', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no unit for many fields while we have units for other equipments. To discuss with PO if they want it or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two translation keys ended with suffix '.svar' in order to customize label without unit (demanded by Christelle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE! Unit are added to some label, see 6ae6cfc
fixQAtNominalV: 'Q fixe à tension nominale', | ||
'maxSusceptance.svar': 'Susceptance max', | ||
minSusceptance: 'Susceptance min', | ||
svarRegulationMode: 'Mode de réglage', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RegulationMode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are ratioRegulationMode and phaseRegulationMode at line 58-59, that why I use svar as prefix for Static Var Compensator RegulationMode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE! Finally, I correct these keys as your suggestion.. see 6ae6cfc
'maxSusceptance.svar': 'Susceptance max', | ||
minSusceptance: 'Susceptance min', | ||
svarRegulationMode: 'Mode de réglage', | ||
'svarRegulationMode.off': 'Arrêt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regulationMode.off
regulationMode.reactivePower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem, see my reply above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE! corrected in 6ae6cfc
…o griddyna_expert_filter_svar
Related PRs:
gridsuite/filter#17
gridsuite/filter-server#117
gridsuite/gridexplore-app#439
Demo