[Expert Filter] - Support for StaticVarCompensator equipment type #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thangqp
changed the title
thangqp
changed the title
thangqp
changed the title
This was referenced Jun 3, 2024
Merged
src/main/java/org/gridsuite/filter/utils/expertfilter/ExpertFilterUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/utils/expertfilter/ExpertFilterUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/utils/expertfilter/ExpertFilterUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/filter/expertfilter/BooleanExpertRuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/filter/expertfilter/PropertiesExpertRuleTest.java
Outdated
Show resolved
Hide resolved
Mathieu-Deharbe
approved these changes
Jun 11, 2024
etiennehomer
requested changes
Jun 12, 2024
| @@ -1475,100 +1481,100 @@ private static Stream<Arguments> provideArgumentsForVoltageLevelTest() { | |||
| Mockito.when(voltageLevel1.getHighVoltageLimit()).thenReturn(Double.NaN); | |||
|
|
|||
| return Stream.of( | |||
| // --- EQUALS --- // | |||
There was a problem hiding this comment.
Revert all the tabs plz
etiennehomer
approved these changes
Jun 14, 2024
YES! |
Mathieu-Deharbe
approved these changes
Jun 17, 2024
Comment on lines
197
to
213
| private static String getTerminalFieldValue(FieldType field, @Nullable Terminal terminal) { | ||
| if (terminal == null) { | ||
| return null; | ||
| } | ||
| return switch (field) { | ||
| case CONNECTED, | ||
| CONNECTED_1, | ||
| CONNECTED_2 -> String.valueOf(terminal.isConnected()); | ||
| case REGULATING_TERMINAL_VL_ID -> | ||
| terminal.getVoltageLevel() != null ? | ||
| terminal.getVoltageLevel().getId() : null; | ||
| case REGULATING_TERMINAL_CONNECTABLE_ID -> | ||
| terminal.getConnectable() != null ? | ||
| terminal.getConnectable().getId() : null; | ||
| case REGULATION_TYPE -> terminal.getConnectable() != null ? | ||
| RegulationType.DISTANT.name() : | ||
| RegulationType.LOCAL.name(); |
There was a problem hiding this comment.
Not sure but I think in the case of a null terminal REGULATION_TYPE should return RegulationType.LOCAL.name(). Isn't it the default mode when a static var compensator has no terminal ?
There was a problem hiding this comment.
DISTANT => the id of connectable equipment must be different to the svar id
LOCAL => otherwise
The correction is DONE in d80d627
|
Mathieu-Deharbe
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gridsuite/filter-server#117
gridsuite/commons-ui#452
gridsuite/gridexplore-app#439