Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite-rule generation using serialized EGraph #67

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Rewrite-rule generation using serialized EGraph #67

wants to merge 10 commits into from

Conversation

thiskappaisgrey
Copy link
Collaborator

This PR adds the rewrite rule generation from Serialized Egraph. It's a WIP right now (still need to generate the module defs), but the LHS is mostly done.

@thiskappaisgrey thiskappaisgrey requested a review from gussmith23 May 4, 2024 13:17
gussmith23
gussmith23 requested changes May 9, 2024
View reviewed changes
Copy link
Owner

@gussmith23 gussmith23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- can you also run cargo clippy --fix to fix the clippy issues?

src/lib.rs Outdated Show resolved Hide resolved
@thiskappaisgrey thiskappaisgrey marked this pull request as ready for review May 16, 2024 00:42
gussmith23
gussmith23 requested changes May 16, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@gussmith23
Copy link
Owner

@thiskappaisgrey can you fix clippy warnings? cargo clippy --fix

@thiskappaisgrey
Copy link
Collaborator Author

@gussmith23 I did but clippy --fix only affected tests/interpreter_tests.rs which I didn't touch in my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gussmith23 gussmith23 gussmith23 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiskappaisgrey @gussmith23