Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yosys-plugin extract syntax #7

Closed
wants to merge 1 commit into from
Closed

Fix yosys-plugin extract syntax #7

wants to merge 1 commit into from

Conversation

ninehusky
Copy link
Collaborator

Closes #6 .

@ninehusky
Copy link
Collaborator Author

@gussmith23 looks like CI is failing because of a permission related issue?

@gussmith23
Copy link
Owner

Just re-ran CI, unsure what is going on with that error and I'm hoping it's just spurious (but it's probably not)

@gussmith23
Copy link
Owner

Something is going wrong with the GITHUB_TOKEN permissions when you specifically are triggering the workflow. The workflow specifically requests write permissions on packages. When the workflow is triggered by me, we see this:

image

But when you trigger:

image

Will keep debugging.

@gussmith23
Copy link
Owner

It looks like this is just default expected behavior from GitHub Actions:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication

Forks can't really ever get write permissions.

@ninehusky I just gave you write access to the repo -- can you push your branch to the repo directly and transition this PR to use that branch? That should resolve the issue. Specifically:

  1. add this repo as a remote git remote add uwsampl [email protected]:uwsampl/churchroad
  2. push your branch git push <branch name> uwsampl
  3. On this PR, hit the "edit" to the right of the PR title, and see if you can change the "from" branch from ninehusky:main to the branch you just pushed.
  4. If you can't do 3, then close this PR and reopen a new one (and make sure to mention this PR in the new PR)

@ninehusky ninehusky mentioned this pull request Feb 23, 2024
@ninehusky
Copy link
Collaborator Author

Closed by #10 .

@ninehusky ninehusky closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Churchroad-yosys write_lakeroad command yields incorrect syntax?
2 participants