Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http4s & http4s-jdk-http-client #290

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Upgrade http4s & http4s-jdk-http-client #290

merged 2 commits into from
Sep 3, 2023

Conversation

gvolpe
Copy link
Owner

@gvolpe gvolpe commented Sep 3, 2023

With the upgrade of http4s, smoke tests break, as reported on #285 . Output:

<<< WS conn error: Output closed
<<< WS conn error: Output closed
2023-09-03T19:27:41,654 [io-compute-1] INFO trading.lib.Logger - {"flow":"out","payload":{"Create":{"id":"2b23aa5a-78ac-449b-9d69-d9633be03d60","cid":"cb35e68d-a269-42a9-92e7-77cc4fd891f5","symbol":"EURUSD","tradeAction":{"Ask":{}},"price":4.5,"quantity":10,"source":"test","createdAt":"2023-09-03T17:27:38.486297230Z"}},"topic":"persistent://public/default/trading-commands"}
2023-09-03T19:27:41,738 [io-compute-5] INFO trading.lib.Logger - {"flow":"out","payload":{"Create":{"id":"d71a5642-4c61-45a0-b699-c48ae33bf35b","cid":"2c637f0a-6a22-4667-8c65-50e7f696aadd","symbol":"CHFEUR","tradeAction":{"Ask":{}},"price":2.3,"quantity":55,"source":"test","createdAt":"2023-09-03T17:27:38.486297230Z"}},"topic":"persistent://public/default/trading-commands"}
2023-09-03T19:27:41,838 [io-compute-10] INFO trading.lib.Logger - {"flow":"out","payload":{"Create":{"id":"0150a458-f81e-4b5a-9b34-7ff50eaf58cb","cid":"0d538820-1c11-40e1-b809-ff1ffa07b89f","symbol":"USDCAD","tradeAction":{"Bid":{}},"price":3.7,"quantity":7,"source":"test","createdAt":"2023-09-03T17:27:38.486297230Z"}},"topic":"persistent://public/default/trading-commands"}
2023-09-03T19:27:41,938 [io-compute-5] INFO trading.lib.Logger - {"flow":"out","payload":{"Create":{"id":"10b0fb67-0817-4478-9534-265fc14890bf","cid":"e94f19b4-8504-4098-8a02-7e55c6afdbc2","symbol":"GBPUSD","tradeAction":{"Bid":{}},"price":2.6,"quantity":89,"source":"test","createdAt":"2023-09-03T17:27:38.486297230Z"}},"topic":"persistent://public/default/trading-commands"}
2023-09-03T19:27:42,38 [io-compute-8] INFO trading.lib.Logger - {"flow":"out","payload":{"Update":{"id":"2c704372-d5bf-48c8-a49f-ba47a3346735","cid":"f97c8bb0-1c3c-4862-9750-3c24ff1c79f1","symbol":"GBPUSD","tradeAction":{"Bid":{}},"price":2.8,"quantity":24,"source":"test","createdAt":"2023-09-03T17:27:38.486297230Z"}},"topic":"persistent://public/default/trading-commands"}

--- WsOut list ---
List()
[info] smokey.Smokey
[info] - Trading smoke test 3s
[info] *************FAILURES**************
[info] smokey.Smokey
[error] - Trading smoke test 3s
[error]   Expected 5 messages (modules/x-qa/src/test/scala/smokey/Smokey.scala:138)
[error]
[error] Failed: Total 1, Failed 1, Errors 0, Passed 0
[error] Failed tests:
[error] 	smokey.Smokey
[error] (smokey / Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 6 s, completed Sep 3, 2023, 7:27:44 PM

UPDATE: upgrading http4s-jdk-http-client to the latest 1.0.0-M9 fixes the issue.


closes #277
closes #267

@gvolpe gvolpe changed the title Upgrade http4s to 1.0.0-M40 Upgrade http4s & http4s-jdk-http-client Sep 3, 2023
@gvolpe gvolpe enabled auto-merge (squash) September 3, 2023 19:56
@gvolpe gvolpe merged commit f32f0af into main Sep 3, 2023
2 checks passed
@gvolpe gvolpe deleted the upgrade-http4s branch September 3, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant