Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1352 Logo component refactor #1633

Merged
merged 4 commits into from
Nov 6, 2024
Merged

1352 Logo component refactor #1633

merged 4 commits into from
Nov 6, 2024

Conversation

eburdekin
Copy link
Member

Fixes #1352

Changes Made

  • Refactor the Logo component to accept an imageOnly prop and render the appropriate logo(s) based on the prop value.
  • Remove unnecessary code from previous designs where text logo appeared in footer as well

Reason for Changes

  • The current implementation of the Logo component used in the header & footer separates the logic for text and image logos. There's separate conditional rendering for each. This can lead to potential inconsistencies and make maintenance more difficult.
  • Text logo no longer included in footer so we can get rid of that code

Action Items

  • change base branch to dev
  • review PR files to guarantee ONLY relevant code is present
  • add ready for dev lead task ready for dev lead to evaluate label

@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Oct 25, 2024
@eburdekin eburdekin linked an issue Oct 25, 2024 that may be closed by this pull request
Refactor Logo component logic #1352
Closed
3 tasks
@sydneywalcoff sydneywalcoff mentioned this pull request Nov 5, 2024
Open
sydneywalcoff
sydneywalcoff approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eburdekin Thanks Eileen! This looks great!!

@sydneywalcoff sydneywalcoff merged commit 5da89f6 into dev Nov 6, 2024
1 check passed
@eburdekin eburdekin deleted the 1352-logo-refactor branch November 16, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneywalcoff sydneywalcoff sydneywalcoff approved these changes

Assignees
No one assigned
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Logo component logic
2 participants
@eburdekin @sydneywalcoff