supporting thread pin on http https and healthz frontend #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @cxfcxf we will look at it. in the mean time CI is complaining about commit message. in short should in this case be |
oktalz
reviewed
Jul 15, 2024
cxfcxf
force-pushed
the
support_thread_pin
branch
from
be100db to
d1d0df8
Compare
i did a reword on commit, so it should be fixed. |
its best that you do that, however I can do that too (if no objections) |
cxfcxf
force-pushed
the
support_thread_pin
branch
from
d1d0df8 to
cbd520a
Compare
ok i squash second commit. |
|
@cxfcxf thx!, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using ingress controller as external mode, so it would be nice that we can control the thread pin on http/https/healthz for better performance.
The PR is adding those flag to support thread pin for ingress controller to set them on haproxy config.
i don't think its a necessary requirement in term of if the controller is running inside Kubernetes cluster, but it would be a great feature to provide for people running it as external mode.