-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ios version #9
base: master
Are you sure you want to change the base?
Ios version #9
Conversation
add documentation to run app for IOS version
add documentation to run app for IOS version
@@ -1,7 +1,7 @@ | |||
# rnw-github [![Build status](https://build.appcenter.ms/v0.1/apps/5e9d98d7-a605-49c7-b921-94ebda4a0d4e/branches/master/badge)](https://appcenter.ms) [![CircleCI](https://circleci.com/gh/haruelrovix/rnw-github/tree/master.svg?style=svg)](https://circleci.com/gh/haruelrovix/rnw-github/tree/master) | |||
A React Native Web app that fetches GitHub API. | |||
|
|||
- Run on Android and Web 🎉 | |||
- Run on Android, IOS and Web 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andangrd Thanks for your contribution! 👏 Could you please revert unnecessary changes related to Android and resolve the merge conflicts? Thanks.
@@ -137,10 +137,12 @@ android { | |||
} | |||
|
|||
dependencies { | |||
compile project(':react-native-vector-icons') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andangrd could you please revert this file? These changes are unnecessary. It's already there, using implementation
instead of compile
.
implementation project(':appcenter')
implementation project(':appcenter-analytics')
implementation project(':appcenter-crashes')
implementation project(':react-native-vector-icons')
@@ -27,6 +29,10 @@ public boolean getUseDeveloperSupport() { | |||
protected List<ReactPackage> getPackages() { | |||
return Arrays.<ReactPackage>asList( | |||
new MainReactPackage(), | |||
new VectorIconsPackage(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andangrd please revert these changes.
@@ -1,4 +1,7 @@ | |||
rootProject.name = 'creaternwapp' | |||
include ':react-native-vector-icons' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haruelrovix unnecessary changes. Please revert this.
|
||
``` $ yarn add appcenter appcenter-analytics appcenter-crashes --exact ``` | ||
3. Link the plugins to the React Native app by using the react-native link command. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andangrd yeah, seems react-native link
doesn't care whether the package already exists or not.
2. [AppCenter](https://docs.microsoft.com/en-us/appcenter/) | ||
3. [AppCenter for React Native](https://docs.microsoft.com/en-us/appcenter/sdk/getting-started/react-native) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andangrd feel free to add this section if you want.
## Contributors | |
- [haruelrovix](https://github.com/haruelrovix) | |
- [andangrd](https://github.com/andangrd) | |
Add IOS Version