-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ios version #9
base: master
Are you sure you want to change the base?
Ios version #9
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,7 +1,7 @@ | ||||||||||||||
# rnw-github [![Build status](https://build.appcenter.ms/v0.1/apps/5e9d98d7-a605-49c7-b921-94ebda4a0d4e/branches/master/badge)](https://appcenter.ms) [![CircleCI](https://circleci.com/gh/haruelrovix/rnw-github/tree/master.svg?style=svg)](https://circleci.com/gh/haruelrovix/rnw-github/tree/master) | ||||||||||||||
A React Native Web app that fetches GitHub API. | ||||||||||||||
|
||||||||||||||
- Run on Android and Web 🎉 | ||||||||||||||
- Run on Android, IOS and Web 🎉 | ||||||||||||||
- Infinite Scroll | ||||||||||||||
|
||||||||||||||
## Deployment | ||||||||||||||
|
@@ -14,9 +14,10 @@ The `apk` for Android can be downloaded [here](https://appcenter.ms/download?url | |||||||||||||
|
||||||||||||||
Continuous Deployment by [Visual Studio App Center](https://appcenter.ms) for Native and [CircleCI](https://circleci.com/dashboard) for Web. 🔥 | ||||||||||||||
|
||||||||||||||
||Android|Web| | ||||||||||||||
|-|-|-| | ||||||||||||||
|Home|<img src="https://user-images.githubusercontent.com/17120764/46534747-7ddb9f80-c8d3-11e8-9263-ecce29998131.png" width=400 />|<img src="https://user-images.githubusercontent.com/17120764/46603380-13b63b00-cb1d-11e8-915b-80ce9478f00c.png" width=400 />| | ||||||||||||||
||Android|Web|Ios| | ||||||||||||||
|-|-|-|-| | ||||||||||||||
|Home|<img src="https://user-images.githubusercontent.com/17120764/46534747-7ddb9f80-c8d3-11e8-9263-ecce29998131.png" width=400 />|<img src="https://user-images.githubusercontent.com/17120764/46603380-13b63b00-cb1d-11e8-915b-80ce9478f00c.png" width=400 />|<img width="383" alt="screen shot 2018-10-27 at 11 55 16 pm" src="https://user-images.githubusercontent.com/26213148/47606918-f9002380-da43-11e8-8cbe-e707fe06ad9e.png"> | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
## Development | ||||||||||||||
|
||||||||||||||
|
@@ -66,10 +67,35 @@ Continuous Deployment by [Visual Studio App Center](https://appcenter.ms) for Na | |||||||||||||
<img src="https://user-images.githubusercontent.com/17120764/46603258-c639ce00-cb1c-11e8-9e43-b10c1a9b120b.png" width=300 /> | ||||||||||||||
|
||||||||||||||
### iOS | ||||||||||||||
|
||||||||||||||
In theory, it should be can be run on iOS simulator using `yarn ios` command. Have no Mac machine to test it. 😅 | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
You have to run `yarn` or `npm install` first to download the dependencies. | ||||||||||||||
Then simply run `yarn ios`. | ||||||||||||||
|
||||||||||||||
If you got an error related to `AppCenter`, you should follow the steps below, | ||||||||||||||
These are some steps to install AppCenter on Mac OS: | ||||||||||||||
|
||||||||||||||
1. make sure you have installed cocoapods, if you haven't, then run this command on your terminal | ||||||||||||||
|
||||||||||||||
``` $ sudo gem install cocoapods --source http://rubygems.org ``` | ||||||||||||||
2. install app center by executing this command : | ||||||||||||||
|
||||||||||||||
``` $ yarn add appcenter appcenter-analytics appcenter-crashes --exact ``` | ||||||||||||||
3. Link the plugins to the React Native app by using the react-native link command. | ||||||||||||||
``` | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @andangrd yeah, seems |
||||||||||||||
react-native link appcenter | ||||||||||||||
react-native link appcenter-analytics | ||||||||||||||
react-native link appcenter-crashes | ||||||||||||||
``` | ||||||||||||||
4. Run Application again 'yarn ios' | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
In case you need some information about Cocoapods and AppCenter, the following link might be helpful for you: | ||||||||||||||
|
||||||||||||||
1. [Cocoapods](https://guides.cocoapods.org/using/getting-started.html) | ||||||||||||||
2. [AppCenter](https://docs.microsoft.com/en-us/appcenter/) | ||||||||||||||
3. [AppCenter for React Native](https://docs.microsoft.com/en-us/appcenter/sdk/getting-started/react-native) | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @andangrd feel free to add this section if you want.
Suggested change
|
||||||||||||||
## Acknowledgements | ||||||||||||||
|
||||||||||||||
RNW GitHub created using [react-native-web](https://github.com/necolas/react-native-web) and [react-native-elements](https://github.com/react-native-training/react-native-elements). 💖 Bootstrapped with [CRNWA](https://github.com/VISI-ONE/create-react-native-web-app). |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,10 +137,12 @@ android { | |
} | ||
|
||
dependencies { | ||
compile project(':react-native-vector-icons') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @andangrd could you please revert this file? These changes are unnecessary. It's already there, using implementation project(':appcenter')
implementation project(':appcenter-analytics')
implementation project(':appcenter-crashes')
implementation project(':react-native-vector-icons') |
||
compile project(':appcenter-crashes') | ||
compile project(':appcenter-analytics') | ||
compile project(':appcenter') | ||
implementation fileTree(dir: "libs", include: ["*.jar"]) | ||
implementation project(':appcenter') | ||
implementation project(':appcenter-analytics') | ||
implementation project(':appcenter-crashes') | ||
|
||
implementation project(':react-native-vector-icons') | ||
implementation "com.android.support:appcompat-v7:23.0.1" | ||
implementation "com.facebook.react:react-native:+" // From node_modules | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,8 @@ | |
import android.app.Application; | ||
|
||
import com.facebook.react.ReactApplication; | ||
import com.oblador.vectoricons.VectorIconsPackage; | ||
|
||
import com.microsoft.appcenter.reactnative.crashes.AppCenterReactNativeCrashesPackage; | ||
import com.microsoft.appcenter.reactnative.analytics.AppCenterReactNativeAnalyticsPackage; | ||
import com.microsoft.appcenter.reactnative.appcenter.AppCenterReactNativePackage; | ||
|
@@ -27,6 +29,10 @@ public boolean getUseDeveloperSupport() { | |
protected List<ReactPackage> getPackages() { | ||
return Arrays.<ReactPackage>asList( | ||
new MainReactPackage(), | ||
new VectorIconsPackage(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @andangrd please revert these changes. |
||
new AppCenterReactNativeCrashesPackage(MainApplication.this, getResources().getString(R.string.appCenterCrashes_whenToSendCrashes)), | ||
new AppCenterReactNativeAnalyticsPackage(MainApplication.this, getResources().getString(R.string.appCenterAnalytics_whenToEnableAnalytics)), | ||
new AppCenterReactNativePackage(MainApplication.this), | ||
new AppCenterReactNativeCrashesPackage(MainApplication.this, getResources().getString(R.string.appCenterCrashes_whenToSendCrashes)), | ||
new AppCenterReactNativeAnalyticsPackage(MainApplication.this, getResources().getString(R.string.appCenterAnalytics_whenToEnableAnalytics)), | ||
new AppCenterReactNativePackage(MainApplication.this), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
rootProject.name = 'creaternwapp' | ||
include ':react-native-vector-icons' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @haruelrovix unnecessary changes. Please revert this. |
||
project(':react-native-vector-icons').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-vector-icons/android') | ||
|
||
include ':appcenter-crashes' | ||
project(':appcenter-crashes').projectDir = new File(rootProject.projectDir, '../node_modules/appcenter-crashes/android') | ||
include ':appcenter-analytics' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Uncomment the next line to define a global platform for your project | ||
# platform :ios, '9.0' | ||
|
||
target 'creaternwapp' do | ||
pod 'AppCenter/Crashes', '~> 1.9.0' | ||
pod 'AppCenter/Analytics', '~> 1.9.0' | ||
pod 'AppCenterReactNativeShared', '~> 1.8.1' | ||
# Uncomment the next line if you're using Swift or would like to use dynamic frameworks | ||
# use_frameworks! | ||
|
||
# Pods for creaternwapp | ||
|
||
|
||
|
||
platform :ios, '9.0' | ||
target 'creaternwappTests' do | ||
inherit! :search_paths | ||
# Pods for testing | ||
end | ||
|
||
end | ||
|
||
target 'creaternwapp-tvOS' do | ||
# Uncomment the next line if you're using Swift or would like to use dynamic frameworks | ||
# use_frameworks! | ||
|
||
# Pods for creaternwapp-tvOS | ||
|
||
target 'creaternwapp-tvOSTests' do | ||
inherit! :search_paths | ||
# Pods for testing | ||
end | ||
|
||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
PODS: | ||
- AppCenter/Analytics (1.9.0): | ||
- AppCenter/Core | ||
- AppCenter/Core (1.9.0) | ||
- AppCenter/Crashes (1.9.0): | ||
- AppCenter/Core | ||
- AppCenterReactNativeShared (1.8.1): | ||
- AppCenter/Core (= 1.9.0) | ||
|
||
DEPENDENCIES: | ||
- AppCenter/Analytics (~> 1.9.0) | ||
- AppCenter/Crashes (~> 1.9.0) | ||
- AppCenterReactNativeShared (~> 1.8.1) | ||
|
||
SPEC REPOS: | ||
https://github.com/cocoapods/specs.git: | ||
- AppCenter | ||
- AppCenterReactNativeShared | ||
|
||
SPEC CHECKSUMS: | ||
AppCenter: 3cf7b9387549e9703dab068793e404013e8c0cc1 | ||
AppCenterReactNativeShared: 3d804f256b964e040d902d1a215d7866fedae55d | ||
|
||
PODFILE CHECKSUM: cf8d52448319c4375c5d82b7ec0267b0873b61b3 | ||
|
||
COCOAPODS: 1.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏