fine tune logic to filter disks (backport #857) #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit b6a5418)
Vicente-Cheng
approved these changes
Oct 9, 2024
tserong
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Logic disks managed by the raid controller will have the same serial number. This results in disks being deduplicated and ignored.
Solution:
From the sample data available the wwn is unique despite the serial number being the same.
The PR adds a minor tweak to continue comparing disks even if serial number is same and check for wwn uniqueness.
Related Issue:
harvester/harvester#6694
Test plan:
This is an automatic backport of pull request #857 done by [Mergify](https://mergify.com).