Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil in embedded HostCatalog #89

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Check for nil in embedded HostCatalog #89

merged 1 commit into from
Jun 1, 2020

Conversation

mgaffney
Copy link
Member

Addresses @jefferai comment in PR #51:

Below you are accessing ScopeId and PublicId without actually validating that c.HostCatalog is not nil.

@mgaffney mgaffney requested a review from jefferai May 29, 2020 15:28
@mgaffney mgaffney mentioned this pull request May 29, 2020
Merged
6 tasks
@mgaffney mgaffney merged commit 4f3f9ed into master Jun 1, 2020
@mgaffney mgaffney deleted the mgaffney/embedded-store-nil-check branch June 1, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgaffney @jefferai